Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT PULL, USING THE AUTO BUILD TO TEST IF IT WORKS AS ITS FASTER BUILD TIME THAN MY MACHINE #299

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion .github/workflows/release-please.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
release-type: simple
package-name: jasm
extra-files: |
src/GIMI-ModManager.WinUI/GIMI-ModManager.WinUI.csproj
src/JASM.WinUI/JASM.WinUI.csproj
changelog-types: >
[
{ "type": "revert", "section": "Reverts", "hidden": false },
Expand Down
4 changes: 2 additions & 2 deletions Build/Release.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
ELEVATOR_CSPROJ = "src\\Elevator\\Elevator.csproj"
ELEVATOR_OUTPUT_FILE = "src\\Elevator\\bin\\Release\\Publish\\Elevator.exe"

JASM_CSPROJ = "src\\GIMI-ModManager.WinUI\\GIMI-ModManager.WinUI.csproj"
JASM_OUTPUT = "src\\GIMI-ModManager.WinUI\\bin\\Release\Publish\\"
JASM_CSPROJ = "src\\JASM.WinUI\\JASM.WinUI.csproj"
JASM_OUTPUT = "src\\JASM.WinUI\\bin\\Release\Publish\\"

JASM_Updater_CSPROJ = "src\\JASM.AutoUpdater\\JASM.AutoUpdater.csproj"
JASM_Updater_OUTPUT = "src\\\\JASM.AutoUpdater\\bin\\Release\Publish\\"
Expand Down
2 changes: 0 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
JASM is a skin manager for a certain game. Made using WinUI 3 with WinAppSDK.
I made this for fun, for myself and to learn WinUI, but it kinda took off over time.

There may be some "GIMI-ModManager" references throughout the app, that is what I originally called this project. I'll change them eventually.


Download link and images are also available over at [GameBanana](https://gamebanana.com/tools/14574)

Expand Down

This file was deleted.

This file was deleted.

2 changes: 1 addition & 1 deletion src/GenshinGenerator/GenshinGenerator.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
</PropertyGroup>

<ItemGroup>
<ProjectReference Include="..\GIMI-ModManager.Core\GIMI-ModManager.Core.csproj" />
<ProjectReference Include="..\JASM.Core\JASM.Core.csproj" />
</ItemGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion src/JASM.AutoUpdater/MainPageVM.cs
Original file line number Diff line number Diff line change
Expand Up @@ -102,11 +102,11 @@

UpdateProgress.NextStage();
}
catch (TaskCanceledException e)

Check warning on line 105 in src/JASM.AutoUpdater/MainPageVM.cs

View workflow job for this annotation

GitHub Actions / build (Release, x64)

The variable 'e' is declared but never used
{
Stop("User cancelled");
}
catch (OperationCanceledException e)

Check warning on line 109 in src/JASM.AutoUpdater/MainPageVM.cs

View workflow job for this annotation

GitHub Actions / build (Release, x64)

The variable 'e' is declared but never used
{
Stop("User cancelled");
}
Expand Down Expand Up @@ -383,7 +383,7 @@
Log("Clean up finished");
}

// Copied from GIMI-ModManager.WinUI/Services/UpdateChecker.cs
// Copied from JASM.WinUI/Services/UpdateChecker.cs
private const string ReleasesApiUrl = "https://api.github.com/repos/Jorixon/JASM/releases?per_page=2";

private async Task<ApiGitHubRelease?> GetLatestVersionAsync(CancellationToken cancellationToken)
Expand Down Expand Up @@ -423,19 +423,19 @@

private class ApiGitHubRelease
{
public string? html_url;

Check warning on line 426 in src/JASM.AutoUpdater/MainPageVM.cs

View workflow job for this annotation

GitHub Actions / build (Release, x64)

Field 'MainPageVM.ApiGitHubRelease.html_url' is never assigned to, and will always have its default value null
public string? target_commitish;
public string? browser_download_url;

Check warning on line 428 in src/JASM.AutoUpdater/MainPageVM.cs

View workflow job for this annotation

GitHub Actions / build (Release, x64)

Field 'MainPageVM.ApiGitHubRelease.browser_download_url' is never assigned to, and will always have its default value null
public string? tag_name;

Check warning on line 429 in src/JASM.AutoUpdater/MainPageVM.cs

View workflow job for this annotation

GitHub Actions / build (Release, x64)

Field 'MainPageVM.ApiGitHubRelease.tag_name' is never assigned to, and will always have its default value null
public bool prerelease;

Check warning on line 430 in src/JASM.AutoUpdater/MainPageVM.cs

View workflow job for this annotation

GitHub Actions / build (Release, x64)

Field 'MainPageVM.ApiGitHubRelease.prerelease' is never assigned to, and will always have its default value false
public DateTime published_at = DateTime.MinValue;

public ApiAssets[]? assets;

Check warning on line 433 in src/JASM.AutoUpdater/MainPageVM.cs

View workflow job for this annotation

GitHub Actions / build (Release, x64)

Field 'MainPageVM.ApiGitHubRelease.assets' is never assigned to, and will always have its default value null
}

private class GitHubRelease
{
public Version Version;

Check warning on line 438 in src/JASM.AutoUpdater/MainPageVM.cs

View workflow job for this annotation

GitHub Actions / build (Release, x64)

Non-nullable field 'Version' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the field as nullable.
public bool PreRelease;
public DateTime PublishedAt = DateTime.MinValue;

Expand Down Expand Up @@ -525,7 +525,7 @@
internal class ApiAssets
{
public string? name;
public string? browser_download_url;

Check warning on line 528 in src/JASM.AutoUpdater/MainPageVM.cs

View workflow job for this annotation

GitHub Actions / build (Release, x64)

Field 'ApiAssets.browser_download_url' is never assigned to, and will always have its default value null
}

public class LogEntry
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
2 changes: 1 addition & 1 deletion src/JASM.Tests/CharactersJsonTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ namespace JASM.Tests;
public class CharactersJsonTests : IDisposable
{
private readonly string AssetsUriPath =
Path.GetFullPath("..\\..\\..\\..\\GIMI-ModManager.WinUI\\Assets\\Games\\Genshin");
Path.GetFullPath("..\\..\\..\\..\\JASM.WinUI\\Assets\\Games\\Genshin");

private readonly string _tmpDataDirectory =
Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.LocalApplicationData),
Expand Down
2 changes: 1 addition & 1 deletion src/JASM.Tests/JASM.Tests.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
</ItemGroup>

<ItemGroup>
<ProjectReference Include="..\GIMI-ModManager.Core\GIMI-ModManager.Core.csproj" />
<ProjectReference Include="..\JASM.Core\JASM.Core.csproj" />
</ItemGroup>

</Project>
File renamed without changes.
File renamed without changes.
Loading
Loading