Conflict with Ultimate Member - "Form Changed" popup

[neilgilmour]

Expected Behavior

Navigating Ultimate Member pages in WP admin is a smooth and pleasant journey. Or at least as smooth and pleasant as it can be for Ultimate Member.

Actual Behavior

Navigating Ultimate Member pages in WP admin is not a smooth and pleasant journey. Every page change triggers a "Leave this page? content not saved" error.

Steps to Reproduce the Problem

1. Install VAA
2. Install Ultimate Member
3. navigate round some UM pages
4. throw computer out of window in frustration

Specifications

• Plugin Version: 1.8
• WordPress Version: 4.9.6
• Other plugins installed: Ultimate Member 2.0.17
• Theme: TwentySeventeen
• Browser: Chrome

[JoryHogeveen]

@neilgilmour
Quick question, are you in a view when this error shows?
And are you using the free version?

[neilgilmour]

No, default view. Free version of UM

…

On Wed, 27 Jun 2018 at 19:09, Jory Hogeveen ***@***.***> wrote: @neilgilmour <https://github.com/neilgilmour> Quick question, are you in a view when this error shows? And are you using the free version? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#93 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADSFVi00SAr-y1kqCyhUQ_6xhM8hC-NDks5uA8pfgaJpZM4U5zbA> .

[JoryHogeveen]

Are you sure the issue is with VAA?
Just installed Ultimate Member free on my dev site and can't find any noticeable changes in load time.

[JoryHogeveen]

Ah, hold on, I get what you mean! It's not about the load time but about the form-notice you get.
Funny thing, I noticed this with WooCommerce etc. too but it didn't came to mind that it could be VAA.
Will look into this!

[JoryHogeveen]

@neilgilmour
See commit 7724e22.
The problem was that JS was triggering a change on load to start some conditional handing but that also triggers the browser into believing that something in a form object was actually changed (which is not the case).