Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reversed usage zm #3

Merged
merged 2 commits into from
Oct 11, 2021
Merged

Add reversed usage zm #3

merged 2 commits into from
Oct 11, 2021

Conversation

menghif
Copy link
Contributor

@menghif menghif commented Oct 9, 2021

Fixes #2

This PR implements the reverse usage zm.
I have updated the README and added tests for zm based on the current mz tests.

Usage:

const template = zm`number is {singular|plural}`
template(5)
template(0)

Please let me know if this implementation makes sense and what could be changed. Thank you!

@menghif menghif changed the title Add reversed usage zm. Update README. Add zm tests Add reversed usage zm Oct 9, 2021
JoschuaSchneider
JoschuaSchneider requested changes Oct 10, 2021
View reviewed changes
Copy link
Owner

@JoschuaSchneider JoschuaSchneider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your work!

I left you a review of the changes and I will turn on the checks for this PR.
Let me know if you have any questions :)

src/index.ts Outdated Show resolved Hide resolved
src/mehrzahl.ts Outdated Show resolved Hide resolved
src/mehrzahl.ts Outdated Show resolved Hide resolved
src/mehrzahl.ts Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@menghif
Copy link
Contributor Author

menghif commented Oct 10, 2021

I made the suggested changes. Thanks for the help!

@JoschuaSchneider JoschuaSchneider merged commit 264f21a into JoschuaSchneider:main Oct 11, 2021
@JoschuaSchneider
Copy link
Owner

Awesome, thanks again for your work on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoschuaSchneider JoschuaSchneider JoschuaSchneider approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add reversed usage zm
2 participants
@menghif @JoschuaSchneider