-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add use of a Swift Package to test caching #2
Open
JosephDuffy
wants to merge
14
commits into
master
Choose a base branch
from
swiftpm-cache
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://bugs.swift.org/browse/SR-11760 might be caused by the loss of fractional timestamps. actions/toolkit#475 should store fractional timestamps as part of the cache, but has not been merged yet. I expect the cache to not reduce the runtime currently.
JosephDuffy
force-pushed
the
swiftpm-cache
branch
from
June 2, 2020 12:27
6edc828
to
03ae69e
Compare
The cache stops SwiftPM from cloning the repos again, but it still rebuilds. Let's see in the toolkit update fixes this... |
Runners now use a path that does not change between releases
JosephDuffy
force-pushed
the
swiftpm-cache
branch
from
August 6, 2020 14:00
4df8d3f
to
4cac2d2
Compare
Re-running the action loses the logs of the first run, making it hard to diagnose changes
Might provide a fresh cache to utilise cache 2.1.1, which uses posix archive format and should allow cache to be used
Should contain 2.1.1 changes to use posix archives
New archives should be created with `--posix`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.swift.org/browse/SR-11760 might be caused by the loss of fractional timestamps. actions/toolkit#475 should store fractional timestamps as part of the cache, but has not been merged yet.
I expect the cache to not reduce the runtime currently.