Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the getClipboardInstance() methods #505

Merged
merged 1 commit into from
Feb 21, 2020

Conversation

JosephSilber
Copy link
Owner

Since Laravel 5.3, Container::getInstance() always returns an instance of the container; if an instance hadn't been registered as a singleton, it registers a new one on the fly.

Since we no longer support older versions of Laravel, we can inline the getInstance call wherever we use it. This removes the need for precedence rules - both in Bouncer itself, and for userland code.

@JosephSilber JosephSilber merged commit bc9d735 into master Feb 21, 2020
@JosephSilber JosephSilber deleted the remove-get-clipboard-instance branch February 21, 2020 03:20
@ziming
Copy link
Contributor

ziming commented Feb 21, 2020

Nice. Look forward to the new tagged release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants