Fix #372 since whereColumn automatically prepend table prefix #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Would you be able to add tests for this? |
|
@JosephSilber Thank you for merging this, is there a new tagged release coming out soon? |
As soon as you, I or anyone else can find the time to write a test for this. |
JosephSilber
added a commit
that referenced
this pull request
Mar 30, 2020
|
The new RC8 release includes this fix 👍 |
tszulc
added a commit
to RoomRoster/bouncer
that referenced
this pull request
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #372
Problem trying to solve
whereColumnmethod already prepend table prefixes for columns.This PR removes the duplicate prefix as it's currently produces db errors.
Scenario
PHP v7.4.3
Laravel v7.1.3
Bouncer v1.0.0-rc.7
Config (with database table prefix)
I didn't try Bouncer v1.0.0-rc.7 with Laravel v6, but currently the
whereColumnmethod seems to be consistent with other database query grammer, and it's being prefixed as expected.