Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #497 #499

Closed
wants to merge 4 commits into from
Closed

fixes #497 #499

wants to merge 4 commits into from

Conversation

localagi
Copy link
Contributor

Description

  • build arm64 only on release and manual trigger ==eqals== only amd64 builds on PR and main pushes
  • tag PR docker releases correctly, provide full test pipeline and green checkmarks

Motivation and Context

How has this been tested?

Screenshots (if appropriate)

Types of changes

Changes visible to users:

  • Bug fix (prefix: fix - non-breaking change which fixes an issue)
  • New feature (prefix: feat - non-breaking change which adds functionality)
  • Breaking change (prefix: feat!! or fix!! - fix or feature that would cause existing functionality to not work as expected)

Internal changes:

  • Refactor (prefix: refactor - non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)
  • Tests (prefix: test - additions and improvements to unit tests and the smoke tests)
  • Infrastructure (prefix: chore - examples include GitHub Actions, issue templates)

Checklist

  • My code follows the code style of this project and passes yarn run lint.
  • My change requires a change to the documentation.
  • My change works!

@localagi
Copy link
Contributor Author

#497

@localagi
Copy link
Contributor Author

localagi commented May 28, 2023

wip...should be avail in a few mins at ghcr.io/josh-xt/agixt:pr-499

we disabled docker hub for PRs, so it lands on gh

@localagi localagi force-pushed the fixes_497 branch 4 times, most recently from 8de44e7 to 3cd5fb4 Compare May 28, 2023 18:30
@Josh-XT
Copy link
Owner

Josh-XT commented May 28, 2023

Let me know whenever you want me to merge it.

@localagi
Copy link
Contributor Author

Opened a bug for help: docker/build-push-action#870

Signed-off-by: localagi <132956819+localagi@users.noreply.github.com>
@localagi
Copy link
Contributor Author

localagi commented Jun 3, 2023

@Josh-XT how can i issue a docker build on this?

@Josh-XT
Copy link
Owner

Josh-XT commented Jun 3, 2023

I can merge if you want

@Josh-XT Josh-XT closed this Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants