Raise minimum python version to 3.11.2 #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshKarpel
requested changes
Dec 30, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #81 +/- ##
=====================================
Coverage 20.6% 20.6%
=====================================
Files 34 34
Lines 3595 3595
Branches 303 303
=====================================
Hits 741 741
Misses 2850 2850
Partials 4 4 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Josh Karpel <josh.karpel@gmail.com>
JoshKarpel
approved these changes
Dec 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than building a clever workaround to address the bug caused by python/cpython#100098, I thought I'd just bump the version constraint on python in the
pyproject.tomlto ensure that others don't bump into this issue.Tasks
pyproject.tomlis self-documenting, but happy to add something to the docs if you'd like.)