-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize runtimes #235
Merged
Merged
Standardize runtimes #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…abbing authorities fro mthe runtime.
@andresilva I've written this PR after our riot conversation the other day. It converts the recipes' nodes to instant-seal as you suggested. I'm hoping you could:
|
dvdplm
reviewed
May 7, 2020
Co-authored-by: David <dvdplm@gmail.com>
Co-authored-by: David <dvdplm@gmail.com>
JoshOrndorff
commented
May 7, 2020
…eloper-hub/recipes into joshy-standardize-runtimes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes the opinion that a "standard" runtime should not be tied to any particular consensus-related APIs or pallets such as the babe_api or the aura_api. Existing nodes are converted to instant-seal. This allows pruning of the pow-runtime, and opens up the possibility of adding some interesting recipes in a natural way in the future. For example:
This PR includes:
Figure out how to make the light client actually build in the instant- and manual-seal nodesThis is figued out and demonstrated in Manual seal light client #238 but needs an upstream PR. FIXME annotations are added to the code here.Write up babe-grandpa recipe (mention node template is similar with aura instead of babe)This is deferred to a followup Add writeup for babe grandpa node #239