Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🛠 Tooling: dist/ directory includes *.test.* files #184

Open
3 tasks done
JoshuaKGoldberg opened this issue Jan 6, 2024 · 1 comment
Open
3 tasks done

🛠 Tooling: dist/ directory includes *.test.* files #184

JoshuaKGoldberg opened this issue Jan 6, 2024 · 1 comment
Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

See file changes in #182: the dist/ directory built by build:release includes artifacts from test. This doesn't hurt anything but is a little sloppy IMO.

  • import { Locator, Octokit } from "./types.js";
    export type ExistingContributions = Record<string, Set<string> | undefined>;
    export declare function getExistingContributors(octokit: Octokit, locator: Locator): Promise<ExistingContributions>;
  • {"version":3,"file":"","sourceRoot":"","sources":["file:///Users/josh/repos/all-contributors-auto-action/src/getExistingContributors.ts"],"names":[],"mappings":"AAGA,OAAO,EAAyB,OAAO,EAAE,OAAO,EAAE,MAAM,YAAY,CAAC;AAErE,MAAM,MAAM,qBAAqB,GAAG,MAAM,CAAC,MAAM,EAAE,GAAG,CAAC,MAAM,CAAC,GAAG,SAAS,CAAC,CAAC;AAI5E,wBAAsB,uBAAuB,CAC5C,OAAO,EAAE,OAAO,EAChB,OAAO,EAAE,OAAO,GACd,OAAO,CAAC,qBAAqB,CAAC,CAoChC"}

Additional Info

cc @johnnyreilly - not something we need to change or account for in JoshuaKGoldberg/create-typescript-app#1196 I don't think, but something to keep in mind maybe?

@JoshuaKGoldberg JoshuaKGoldberg added area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :( labels Jan 6, 2024
@johnnyreilly
Copy link

Yeah I handled it in Schemar by having a test directory: https://github.com/johnnyreilly/schemar/tree/main/test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Development

No branches or pull requests

2 participants