-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: how to create a GitHub Action #1196
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks Passed!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1196 +/- ##
==========================================
- Coverage 94.81% 94.79% -0.03%
==========================================
Files 104 103 -1
Lines 5804 5781 -23
Branches 492 490 -2
==========================================
- Hits 5503 5480 -23
Misses 300 300
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great! I left a bunch of nits because that's who I am as a person 😄 but fundamentally I really like this guide. Thanks for getting it started!
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
as predicted, my return to work has laid waste to my OSS time. I've done a few edits - where do things stand with this? |
gah now pnpm run build is failing with out of memory:
|
Fixed by |
Okay I'm baffled now. I haven't changed anything, but I'm now seeing this failure in the tests:
I haven't changed anything - why would the tests be failing?! |
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
Yeah sorry, that was a break on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is really close to merge, thanks! Just a few small touchups. I could make them myself but want to get your input. 🙂
docs/FAQs.md
Outdated
4. Our GitHub Action needs Node.js 20 so we'll update `.github/actions/prepare/action.yml`: | ||
|
||
```diff | ||
-node-version: "18" | ||
+node-version: "20" | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
Yo @JoshuaKGoldberg! I'm back home! I think I've now looked at all the feedback - not sure though; still not quite trusting GitHub to surface stuff. Are we there? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this is looking great, thank you so much (as always) @johnnyreilly for dealing with my pickiness and GitHub shenanigans!
Let's get this merged 🚀
Test failures are unrelated. Sigh. |
@all-contributors please add @johnnyreilly for doc.
|
I've put up a pull request to add @johnnyreilly! 🎉 I couldn't determine any contributions to add, did you specify any contributions? |
Adds @johnnyreilly as a contributor for doc. This was requested by JoshuaKGoldberg [in this comment](#1196 (comment)) --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
🎉 This is included in version v1.57.0 🎉 The release is available on: Cheers! 📦🚀 |
PR Checklist
status: accepting prs
Overview
This PR provides docs on how to create a GitHub Action