Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: allcontributors isn't respecting prettierignore #837

Closed
3 tasks done
JoshuaKGoldberg opened this issue Sep 19, 2023 · 2 comments · Fixed by #838
Closed
3 tasks done

🐛 Bug: allcontributors isn't respecting prettierignore #837

JoshuaKGoldberg opened this issue Sep 19, 2023 · 2 comments · Fixed by #838
Labels
type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

After all-contributors/cli#347 -> all-contributors/cli#356 -> #806, the all-contributors GitHub bot should be respecting this repo's Prettier config file.

Actual

#808: it isn't... 😞

Running npx all-contributors-cli on the CLI does work though. Perhaps the GitHub bot is running an out of date version of something?

I'll revert #806.

Additional Info

No response
@JoshuaKGoldberg JoshuaKGoldberg added the type: bug Something isn't working :( label Sep 19, 2023
This was referenced Sep 19, 2023
Closed
Merged
@JoshuaKGoldberg
Copy link
Owner Author

Also filed all-contributors/app#479.

JoshuaKGoldberg added a commit that referenced this issue Sep 19, 2023
@JoshuaKGoldberg
fix: add .allcontributorsrc back to .prettierignore (#838)
cc8a98d 
## PR Checklist

- [x] Addresses an existing open issue: fixes #837
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

😢. #806 was perfect. But the tooling appears to not be working properly.

fyi @conrmahr - maybe we can try again in a few months?
@github-actions
Copy link

🎉 This is included in version v1.29.42 🎉

The release is available on:

Cheers! 📦🚀

@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Sep 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug Something isn't working :(
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add .allcontributorsrc back to .prettierignore JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg