generated from JoshuaKGoldberg/create-typescript-app
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: split file system out into create-fs package, with diffCreatedDirectory tester #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #129 +/- ##
==========================================
+ Coverage 98.35% 98.51% +0.16%
==========================================
Files 174 179 +5
Lines 6124 6520 +396
Branches 896 961 +65
==========================================
+ Hits 6023 6423 +400
+ Misses 98 94 -4
Partials 3 3 ☔ View full report in Codecov by Sentry. |
2 tasks
JoshuaKGoldberg
changed the title
feat: split file system into create-fs, with diffCreatedDirectory tester
feat: split file system out into create-fs package, with diffCreatedDirectory tester
Jan 14, 2025
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prs
Overview
Splits the file system and
files
creation types into a separatecreate-fs
module. They have a few renames, mostly around switchingCreatedFiles
toCreatedDirectory
.Adds two important high-level APIs:
create-fs
>intakeFromDirectory
: Reads files from disk into aCreatedDirectory
ReadingFileSystem
type because I don't want to add the concept offs.stat
to that systemcreate-testers
>diffCreatedDirectory
: Given an actual directory, i.e. fromintakeFromDirectory
, and a produced Creation, returns an object describing their differencesThis is intentionally different from the tester API proposed in #38. I don't feel ready yet to commit to a particular high-level API for repository templates. For now I'd rather provide lower-level pieces and explore using them.
💝