Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow file creations to be [string, { mode }] #29

Merged
merged 3 commits into from
Dec 9, 2024

Conversation

JoshuaKGoldberg
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg commented Dec 9, 2024

PR Checklist

Overview

Allows file creations to be [string, { mode?: number }] per the issue.

Note that this only unit tests the production areas, not runtime (currently: applyCreation -> applyFilesToSystem). Runner APIs haven't been fleshed out yet. That's tracked separately in #21.

💖

Copy link

vercel bot commented Dec 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 9:09pm

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 96.49123% with 6 lines in your changes missing coverage. Please review.

Project coverage is 76.49%. Comparing base (50b99d3) to head (7ccf30d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ages/create/src/cli/applying/applyFilesToSystem.ts 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
+ Coverage   74.30%   76.49%   +2.18%     
==========================================
  Files          62       65       +3     
  Lines        1483     1621     +138     
  Branches      206      238      +32     
==========================================
+ Hits         1102     1240     +138     
  Misses        367      367              
  Partials       14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 09f3e41 into main Dec 9, 2024
16 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the file-modes branch December 9, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Allow attaching metadata to created files
1 participant