Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🛠 Tooling: twoslash tests hang for many seconds after completion #637

Open
3 tasks done
JoshuaKGoldberg opened this issue Nov 29, 2024 · 2 comments
Open
3 tasks done
Labels
area: testing Improving how the repository's tests are run and/or code is tested 🧪 area: tooling Managing the repository's maintenance 🛠️ status: accepting prs Please, send a pull request to resolve this! 🙏

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

$ time pnpm run test run

...


 ✓ src/rules/expect-error.test.ts (2) 915ms
 ✓ src/rules/expect-type-snapshot.test.ts (10) 971ms
 ✓ src/rules/expect-type.test.ts (19) 1011ms
 ✓ src/rules/twoslash.test.ts (20) 7050ms

 Test Files  4 passed (4)
      Tests  51 passed (51)
   Start at  08:50:38
   Duration  7.80s (transform 98ms, setup 22ms, collect 2.10s, tests 9.95s, environment 0ms, prepare 214ms)

pnpm run test run  18.59s user 1.34s system 241% cpu 8.253 total

18 seconds total run, ~7 seconds in expect-type. Huh.

Additional Info

💖

@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send a pull request to resolve this! 🙏 area: testing Improving how the repository's tests are run and/or code is tested 🧪 area: tooling Managing the repository's maintenance 🛠️ labels Nov 29, 2024
@JoshuaKGoldberg
Copy link
Owner Author

@all-contributors please add @JoshuaKGoldberg for tool.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @JoshuaKGoldberg! 🎉

JoshuaKGoldberg pushed a commit that referenced this issue Nov 29, 2024
Adds @JoshuaKGoldberg as a contributor for tool.

This was requested by JoshuaKGoldberg [in this
comment](#637 (comment))

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: testing Improving how the repository's tests are run and/or code is tested 🧪 area: tooling Managing the repository's maintenance 🛠️ status: accepting prs Please, send a pull request to resolve this! 🙏
Projects
None yet
Development

No branches or pull requests

1 participant