-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Firefox support with web-ext #177
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #177 +/- ##
=======================================
Coverage 10.73% 10.73%
=======================================
Files 6 6
Lines 326 326
Branches 8 8
=======================================
Hits 35 35
Misses 291 291 ☔ View full report in Codecov by Sentry. |
@@ -83,8 +84,8 @@ | |||
"should-semantic-release": "^0.2.1", | |||
"typescript": "^5.2.2", | |||
"vitest": "^0.34.6", | |||
"yaml-eslint-parser": "^1.2.2", | |||
"zip-lib": "^0.7.3" | |||
"web-ext": "^7.8.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe something to look into later on...
WARN 3 deprecated subdependencies found: har-validator@5.1.5, request@2.88.2, uuid@3.4.0
Already up to date
Progress: resolved 989, reused 947, downloaded 0, added 0, done
WARN Issues with peer dependencies found
.
└─┬ web-ext 7.8.0
└─┬ addons-linter 6.13.0
└─┬ addons-scanner-utils 9.3.0
└── ✕ unmet peer node-fetch@2.6.11: found 3.3.1 in web-ext
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the deprecation warnings: mozilla/sign-addon#932.
For node-fetch
: mozilla/addons-scanner-utils#271.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aha! Nice. mozilla/web-ext#2737
This will all be fixed soon.
@all-contributors please add @luisestevez.me> for code.
|
Could not find the user |
Fixes #7. |
PR Checklist
status: accepting prs
Overview
Adds https://extensionworkshop.com's
web-ext
tool instead of the existingzip
script to build a Firefox-ready zip, and adds development + production docs for Firefox alongside the existing Chrome ones.Doesn't yet look into Edge or Safari. That can be a next step or two for the rest of #7.
cc @estevezluis @schalkneethling - builds off the changes in #153.
Co-authored-by: Schalk Neethling schalk@mechanical.ink
Co-authored-by: Luis Estevez contact@luisestevez.me