Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Firefox support with web-ext #177

Merged
merged 3 commits into from
Nov 16, 2023
Merged

Conversation

JoshuaKGoldberg
Copy link
Owner

PR Checklist

Overview

Adds https://extensionworkshop.com's web-ext tool instead of the existing zip script to build a Firefox-ready zip, and adds development + production docs for Firefox alongside the existing Chrome ones.

Doesn't yet look into Edge or Safari. That can be a next step or two for the rest of #7.

cc @estevezluis @schalkneethling - builds off the changes in #153.

Co-authored-by: Schalk Neethling schalk@mechanical.ink
Co-authored-by: Luis Estevez contact@luisestevez.me

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (32e4165) 10.73% compared to head (6e36e01) 10.73%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #177   +/-   ##
=======================================
  Coverage   10.73%   10.73%           
=======================================
  Files           6        6           
  Lines         326      326           
  Branches        8        8           
=======================================
  Hits           35       35           
  Misses        291      291           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -83,8 +84,8 @@
"should-semantic-release": "^0.2.1",
"typescript": "^5.2.2",
"vitest": "^0.34.6",
"yaml-eslint-parser": "^1.2.2",
"zip-lib": "^0.7.3"
"web-ext": "^7.8.0",
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something to look into later on...

 WARN  3 deprecated subdependencies found: har-validator@5.1.5, request@2.88.2, uuid@3.4.0
Already up to date
Progress: resolved 989, reused 947, downloaded 0, added 0, done
 WARN  Issues with peer dependencies found
.
└─┬ web-ext 7.8.0
  └─┬ addons-linter 6.13.0
    └─┬ addons-scanner-utils 9.3.0
      └── ✕ unmet peer node-fetch@2.6.11: found 3.3.1 in web-ext

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the deprecation warnings: mozilla/sign-addon#932.

For node-fetch: mozilla/addons-scanner-utils#271.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha! Nice. mozilla/web-ext#2737

This will all be fixed soon.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review November 16, 2023 17:54
@JoshuaKGoldberg JoshuaKGoldberg merged commit 342551b into main Nov 16, 2023
14 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the firefox-web-ext branch November 16, 2023 17:58
@JoshuaKGoldberg
Copy link
Owner Author

@all-contributors please add @luisestevez.me> for code.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

Copy link
Contributor

@JoshuaKGoldberg

Could not find the user luisestevez.me> on github.

@JoshuaKGoldberg
Copy link
Owner Author

Fixes #7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant