Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug: dynamic metadata description is misleading when username doesn't exist #844

Open
3 tasks done
maggienegm opened this issue Jan 10, 2025 · 0 comments
Open
3 tasks done
Labels
type: bug Something isn't working :(

Comments

@maggienegm
Copy link
Contributor

maggienegm commented Jan 10, 2025

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

This is a follow up issue from #842.

If a username doesn't exist in npm, the generated metadata should return a description that says something along the lines of:

Could not find {username} on npm.

Actual

Currently, if a username doesn't exist, the metadata description that is returned is:

{username} has 0 npm packages eligible for Tidelift funding. 💸

This is misleading.

Additional Info

The dynamic metadata logic generates the metadata description based off the results from the tidelife-me-up package. However, the tidelife-me-up package currently doesn't handle the case where the username doesn't exist. There is an open issue to fix this: JoshuaKGoldberg/tidelift-me-up#17.

So this issue is blocked until the open issue in the tidelife-me-up repo is fixed.

@maggienegm maggienegm added the type: bug Something isn't working :( label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working :(
Projects
None yet
Development

No branches or pull requests

1 participant