-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add dynamic metadata for search results #842
feat: add dynamic metadata for search results #842
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
4a2c649
to
e22c518
Compare
e22c518
to
5ff089f
Compare
Just noting for future reference, some test values:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 This is looking great, thank you so much! Really excited to finally fix this darn accessibility/title bug.
Left a few comments and I think only about half of them are actually blockers. LMK what you think! 🙌
I just wanted to note that I've added caching to ensure data consistency between the
[See comment below 😅] With all that being said, would love to hear your thoughts! |
Replaced |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Checklist
status: accepting prs
Overview
This PR introduces dynamic metadata generation for the home/search page. It's metadata is now dynamically generated based on the
searchParams
in the URL:This includes when a valid user has 0 packages eligible for funding based on search parameters. The metadata will look like the following:
When no
searchParams
are provided, the default metadata is used, which is defined inlayout.tsx
:Also, something to note is that the API-related logic that was in
page.tsx
has been extracted into a separate file to improve code readability and maintainability.