Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🛠 Tooling: "Update Docs" workflow never running #580

Closed
3 tasks done
RebeccaStevens opened this issue Nov 25, 2024 · 1 comment · Fixed by #531
Closed
3 tasks done

🛠 Tooling: "Update Docs" workflow never running #580

RebeccaStevens opened this issue Nov 25, 2024 · 1 comment · Fixed by #531
Labels
area: tooling Managing the repository's maintenance 🛠️ status: accepting prs Please, send a pull request to resolve this! 🙏

Comments

@RebeccaStevens
Copy link
Collaborator

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

This workflow has never run despite the fact that it should run after every release.

https://github.com/JoshuaKGoldberg/ts-api-utils/actions/workflows/docs-update.yml

I guess there's something wrong here:

https://github.com/JoshuaKGoldberg/ts-api-utils/blob/main/.github/workflows/docs-update.yml#L61-L66

Additional Info

It might not be worth fixing as with v2 we won't be using typedoc-plugin-versions which is why this workflow exists. The docs workflows can be much simplified.

@RebeccaStevens RebeccaStevens added the area: tooling Managing the repository's maintenance 🛠️ label Nov 25, 2024
RebeccaStevens added a commit that referenced this issue Nov 25, 2024
remove extra logic that was need for typedoc-plugin-versions

re #580
RebeccaStevens added a commit that referenced this issue Nov 25, 2024
remove extra logic that was need for typedoc-plugin-versions

re #580
@JoshuaKGoldberg JoshuaKGoldberg added the status: accepting prs Please, send a pull request to resolve this! 🙏 label Nov 25, 2024
@RebeccaStevens
Copy link
Collaborator Author

Docs Release also isn't running. This workflow should be triggered whenever changes are pushed to the gh-page branch (thus should be triggered by the Update Docs workflow). But after making manual changes to the gh-pages branch, the workflow didn't run.

I tried adding the workflows to the gh-pages branch too, to make sure the logic on that branch is the same, but this didn't resolve the issue.

I've run things manually so the docs page is up to date now, but I think I might just leave this for now and just work on the more simple workflow needed for v2.

RebeccaStevens added a commit that referenced this issue Nov 25, 2024
remove extra logic that was need for typedoc-plugin-versions

re #580
RebeccaStevens added a commit that referenced this issue Nov 26, 2024
remove extra logic that was need for typedoc-plugin-versions

re #580
RebeccaStevens added a commit that referenced this issue Nov 26, 2024
remove extra logic that was need for typedoc-plugin-versions

re #580
RebeccaStevens added a commit that referenced this issue Nov 26, 2024
remove extra logic that was need for typedoc-plugin-versions

re #580
RebeccaStevens added a commit that referenced this issue Nov 26, 2024
remove extra logic that was need for typedoc-plugin-versions

re #580
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: tooling Managing the repository's maintenance 🛠️ status: accepting prs Please, send a pull request to resolve this! 🙏
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants