Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add a few more unit tests #262

Merged
merged 5 commits into from
Aug 18, 2023
Merged

test: add a few more unit tests #262

merged 5 commits into from
Aug 18, 2023

Conversation

JoshuaKGoldberg
Copy link
Owner

PR Checklist

Overview

It's been bugging me that this package now has >2.5 million downloads but only has 46% coverage. Which Codecov shows as a red color in the badge. 😡

No end user impacts here. Just added test coverage.

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #262 (0fd9d45) into main (f039b2b) will increase coverage by 3.69%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

❗ Current head 0fd9d45 differs from pull request most recent head 6c95baf. Consider uploading reports for the commit 6c95baf to get more accurate results

@@            Coverage Diff             @@
##             main     #262      +/-   ##
==========================================
+ Coverage   46.30%   50.00%   +3.69%     
==========================================
  Files          20       20              
  Lines         460      460              
  Branches      181      181              
==========================================
+ Hits          213      230      +17     
+ Misses        218      203      -15     
+ Partials       29       27       -2     
Flag Coverage Δ
4.3.5 49.34% <ø> (+3.47%) ⬆️
4.6.4 49.56% <ø> (+3.47%) ⬆️
4.9.5 50.00% <ø> (+3.69%) ⬆️
latest 49.78% <ø> (+3.69%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JoshuaKGoldberg JoshuaKGoldberg merged commit 116f976 into main Aug 18, 2023
@JoshuaKGoldberg JoshuaKGoldberg deleted the assorted-tests branch August 18, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant