feat: add missing node type guards

[RebeccaStevens]

PR Checklist

• Addresses an existing open issue
  • fixes 🐛 Bug: isExpression probably doesn't match all expressions #31
  • fixes 🚀 Feature: Remove isTextualLiteral #32
  • closes WIP feat: add missing node type guards. #25
  • re 🚀 Feature: Fill in remaining tsutils functions (that don't exist on TypeScript) #3
• That issue was marked as status: accepting prs
• Steps in CONTRIBUTING.md were taken

Overview

• Adds the missing node type guards from tsutils
• Adds node type guards for node introduced to TypeScript since tsutils was last updated
• Add a bunch of "union node type guards" (node type guards simple made up of unions of other node type guards)
• BREAKING: isExpression removed

When making this PR, I noticed that it's probably possible to auto-generate a bunch of these type-guards; particularly with the ones defined in simple.ts and union.ts. This is probably worth looking into in future.

Note: No additionally test have been added.

[JoshuaKGoldberg]

This is fantastic, thanks for getting so much of this sent @RebeccaStevens! 🎉

Requesting changes to remove some excess functions. Very excited to see it come in!

[RebeccaStevens]

I think this PR is ready other than for knip complaining. I'm not sure why it's complaining.

[JoshuaKGoldberg]

...huh, yeah, me neither. Weird. I'm guessing it's an export * that includes export *s? webpro-nl/knip#62

[JoshuaKGoldberg]

Very close!

For the Knip issues, pending webpro-nl/knip#62, I guess you can add an explicit ignore to the config file. 😞

[RebeccaStevens]

I guess you can add an explicit ignore to the config file

This isn't as easy as you would think it would be.
ignore seems to be "ignore these files entirely", not just "ignore any issue from these files".
So ignore all the files in src/nodes/typeGuards, then there is a cascading effect where createNode is now unused. If I ignore that then the dependency @typescript/vfs is now unused.

[RebeccaStevens]

This isn't as easy as you would think it would be. ignore seems to be "ignore these files entirely", not just "ignore any issue from these files". So ignore all the files in src/nodes/typeGuards, then there is a cascading effect where createNode is now unused. If I ignore that then the dependency @typescript/vfs is now unused.

Ignoring only the non-test files actually seems to resolve this.

Those it's fragile as the files are ignored completely, not just issues ignored.

[JoshuaKGoldberg]

This is fantastic, thanks a million @RebeccaStevens! 🚀 Really appreciate you iterating with me & doing such a thorough job.