Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix for node 16 #547

Merged
merged 6 commits into from
Nov 21, 2024
Merged

build: fix for node 16 #547

merged 6 commits into from
Nov 21, 2024

Conversation

RebeccaStevens
Copy link
Collaborator

@RebeccaStevens RebeccaStevens commented Nov 20, 2024

Not required once #531 is merged was node 16 support is dropped there.
Does some of the same things as that PR.

fix #548

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.88%. Comparing base (c87c47b) to head (344cd8d).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #547      +/-   ##
==========================================
+ Coverage   80.59%   80.88%   +0.29%     
==========================================
  Files          35       35              
  Lines        6575     6655      +80     
  Branches      440      448       +8     
==========================================
+ Hits         5299     5383      +84     
+ Misses       1276     1272       -4     
Flag Coverage Δ
4.3.5 79.65% <ø> (-0.52%) ⬇️
4.6.4 79.68% <ø> (-0.52%) ⬇️
4.9.5 79.68% <ø> (-0.52%) ⬇️
latest 80.48% <ø> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@RebeccaStevens RebeccaStevens changed the title build: use pnpm v8 so we can still test with node v16 build: fix for node 16 Nov 20, 2024
@RebeccaStevens RebeccaStevens enabled auto-merge (squash) November 20, 2024 06:09
@RebeccaStevens RebeccaStevens merged commit bfb1646 into main Nov 21, 2024
22 checks passed
@RebeccaStevens RebeccaStevens deleted the pnpm-node-16-fix branch November 21, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🛠 Tooling: Fix CI for node 16
1 participant