Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added unit tests for matrix arithmetic #108

Merged
merged 9 commits into from
Aug 29, 2019
Merged

Added unit tests for matrix arithmetic #108

merged 9 commits into from
Aug 29, 2019

Conversation

regexident
Copy link
Collaborator

This was referenced Aug 6, 2019
Closed
Merged
@mattt mattt self-requested a review August 19, 2019 13:54
mattt
mattt reviewed Aug 19, 2019
View reviewed changes
Copy link
Collaborator

@mattt mattt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes unique to this PR look great. Holding final approval pending resolution of the dependent PRs.

@regexident regexident merged commit cc1a716 into Jounce:master Aug 29, 2019
@regexident regexident deleted the matrix-tests branch August 29, 2019 22:48
@regexident regexident mentioned this pull request Nov 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattt mattt mattt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@regexident @mattt