Added functions for generating uniform/normal distributed randomness #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cting with `no_extension_access_modifier` rule
mattt
approved these changes
Oct 28, 2019
There was a problem hiding this comment.
Great work, @regexident! Only question I had was about the naming of randUniform & randNormal. Would it make sense to expand to randomUniform & randomNormal for clarity? Or is the use of rand in keeping with other well-known abbreviations whose use is less conspicuous than expanding to a more descriptive name (e.g. det(_:) -> determinant(of:))?
|
Yeah, I was keeping it short, to blend in with the rest of Surge. I'm 50/50 between |
|
Let's go for |
regexident
force-pushed
the
randomness
branch
from
49ebd0d
to
9b93025
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this is a purely additive change I figured we actually don't need to wait for a v3.x.
We have plenty of stuff on our plate for that already.
Resolves #144