modules/steam: Fix SteamOS logo scaling in updater #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samueldr
added
2. priority: 2. normal
2. topic: system integration
samueldr
force-pushed
the
feature/updater-steamos-logo-fix
branch
from
3894ecc
to
3d1cdb7
Compare
K900
reviewed
Nov 1, 2024
This implementation may look weird with the three `MAGICK_INVOCATION` following each-others, but there's a reason for it: I already know the script will gain support for “just” splatting the BGRT. As such, the middle `MAGICK_INVOCATION` will be conditional on whether or not it's building from BGRT.
This is a workaround / fixup. BGRT support will be added later on.
samueldr
force-pushed
the
feature/updater-steamos-logo-fix
branch
from
3d1cdb7
to
617d644
Compare
|
Now implemented via a system-wide service, with a system-wide Do note that this now has to rely on re-implementing some trivial logic to get the appropriate updater splash. So in a future where the vendor implementation changes or gets enhanced, this will need to be updated too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #282, but without the BGRT challenges. That other PR will be rebased on top of this.