Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 175 javadoc for all visibility #197

Merged
merged 3 commits into from
Jun 25, 2017
Merged

Issue 175 javadoc for all visibility #197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b9711ac
Address #175 by configuring the Javadoc Maven plugin to generate docu…
DavidWhitlock Jun 24, 2017
28d5ce7
Add an integration test for the PhoneBill project archetype that veri…
DavidWhitlock Jun 24, 2017
2928338
Continue to address issue #175 by adding archetype integration tests …
DavidWhitlock Jun 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions gwt-parent/gwt-originals-parent/airline-gwt/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,9 @@
<profiles>
<profile>
<id>grader</id>
<activation>
<activeByDefault>${grader}</activeByDefault>
</activation>
<build>
<plugins>
<plugin>
Expand All @@ -198,6 +201,7 @@
<version>Summer2017</version>
</docletArtifact>
<useStandardDocletOptions>false</useStandardDocletOptions>
<show>private</show>
</configuration>
</plugin>
</plugins>
Expand Down
4 changes: 4 additions & 0 deletions gwt-parent/gwt-originals-parent/apptbook-gwt/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,9 @@
<profiles>
<profile>
<id>grader</id>
<activation>
<activeByDefault>${grader}</activeByDefault>
</activation>
<build>
<plugins>
<plugin>
Expand All @@ -199,6 +202,7 @@
<version>Summer2017</version>
</docletArtifact>
<useStandardDocletOptions>false</useStandardDocletOptions>
<show>private</show>
</configuration>
</plugin>
</plugins>
Expand Down
4 changes: 4 additions & 0 deletions gwt-parent/gwt-originals-parent/phonebill-gwt/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,9 @@
<profiles>
<profile>
<id>grader</id>
<activation>
<activeByDefault>${grader}</activeByDefault>
</activation>
<build>
<plugins>
<plugin>
Expand All @@ -198,6 +201,7 @@
<version>Summer2017</version>
</docletArtifact>
<useStandardDocletOptions>false</useStandardDocletOptions>
<show>private</show>
</configuration>
</plugin>
</plugins>
Expand Down
4 changes: 4 additions & 0 deletions ...parent/archetypes-parent/airline-archetype/src/main/resources/archetype-resources/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,9 @@
<profiles>
<profile>
<id>grader</id>
<activation>
<activeByDefault>${grader}</activeByDefault>
</activation>
<build>
<plugins>
<plugin>
Expand All @@ -141,6 +144,7 @@
<version>Summer2017</version>
</docletArtifact>
<useStandardDocletOptions>false</useStandardDocletOptions>
<show>private</show>
</configuration>
</plugin>
</plugins>
Expand Down
5 changes: 5 additions & 0 deletions ...hetypes-parent/airline-archetype/src/test/resources/projects/javadoc/archetype.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
package=it.pkg.javadoc
version=0.1-SNAPSHOT
groupId=javadoc.archetype.it
artifactId=javadoc
grader=true
1 change: 1 addition & 0 deletions ...s-parent/archetypes-parent/airline-archetype/src/test/resources/projects/javadoc/goal.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
javadoc:javadoc
11 changes: 11 additions & 0 deletions ...ent/archetypes-parent/airline-archetype/src/test/resources/projects/javadoc/verify.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
File buildLog = new File(basedir, "project/javadoc/build.log");
if (!buildLog.isFile()) {
throw new FileNotFoundException("Couldn't find build log: " + buildLog)
}

String logText = buildLog.text

def expectedJavaDoc = "The main class for the CS410J airline Project"
if (!logText.contains(expectedJavaDoc)) {
throw new IllegalStateException("Didn't find expected JavaDoc: " + expectedJavaDoc)
}
4 changes: 4 additions & 0 deletions ...nt/archetypes-parent/airline-gwt-archetype/src/main/resources/archetype-resources/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,9 @@
<profiles>
<profile>
<id>grader</id>
<activation>
<activeByDefault>${grader}</activeByDefault>
</activation>
<build>
<plugins>
<plugin>
Expand All @@ -197,6 +200,7 @@
<version>Summer2017</version>
</docletArtifact>
<useStandardDocletOptions>false</useStandardDocletOptions>
<show>private</show>
</configuration>
</plugin>
</plugins>
Expand Down
5 changes: 5 additions & 0 deletions ...pes-parent/airline-gwt-archetype/src/test/resources/projects/javadoc/archetype.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
package=it.pkg.javadoc
version=0.1-SNAPSHOT
groupId=javadoc.archetype.it
artifactId=javadoc
grader=true
1 change: 1 addition & 0 deletions ...rent/archetypes-parent/airline-gwt-archetype/src/test/resources/projects/javadoc/goal.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
javadoc:javadoc
11 changes: 11 additions & 0 deletions ...archetypes-parent/airline-gwt-archetype/src/test/resources/projects/javadoc/verify.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
File buildLog = new File(basedir, "project/javadoc/build.log");
if (!buildLog.isFile()) {
throw new FileNotFoundException("Couldn't find build log: " + buildLog)
}

String logText = buildLog.text

def expectedJavaDoc = "A basic GWT class that makes sure that we can send an airline back"
if (!logText.contains(expectedJavaDoc)) {
throw new IllegalStateException("Didn't find expected JavaDoc: " + expectedJavaDoc)
}
4 changes: 4 additions & 0 deletions ...nt/archetypes-parent/airline-web-archetype/src/main/resources/archetype-resources/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,9 @@
<profiles>
<profile>
<id>grader</id>
<activation>
<activeByDefault>${grader}</activeByDefault>
</activation>
<build>
<plugins>
<plugin>
Expand All @@ -202,6 +205,7 @@
<version>Summer2017</version>
</docletArtifact>
<useStandardDocletOptions>false</useStandardDocletOptions>
<show>private</show>
</configuration>
</plugin>
</plugins>
Expand Down
5 changes: 5 additions & 0 deletions ...pes-parent/airline-web-archetype/src/test/resources/projects/javadoc/archetype.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
package=it.pkg.javadoc
version=0.1-SNAPSHOT
groupId=javadoc.archetype.it
artifactId=javadoc
grader=true
1 change: 1 addition & 0 deletions ...rent/archetypes-parent/airline-web-archetype/src/test/resources/projects/javadoc/goal.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
javadoc:javadoc
11 changes: 11 additions & 0 deletions ...archetypes-parent/airline-web-archetype/src/test/resources/projects/javadoc/verify.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
File buildLog = new File(basedir, "project/javadoc/build.log");
if (!buildLog.isFile()) {
throw new FileNotFoundException("Couldn't find build log: " + buildLog)
}

String logText = buildLog.text

def expectedJavaDoc = "A helper class for accessing the rest client."
if (!logText.contains(expectedJavaDoc)) {
throw new IllegalStateException("Didn't find expected JavaDoc: " + expectedJavaDoc)
}
3 changes: 3 additions & 0 deletions ...arent/archetypes-parent/apptbook-archetype/src/main/resources/archetype-resources/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,9 @@
<profiles>
<profile>
<id>grader</id>
<activation>
<activeByDefault>${grader}</activeByDefault>
</activation>
<build>
<plugins>
<plugin>
Expand Down
5 changes: 5 additions & 0 deletions ...etypes-parent/apptbook-archetype/src/test/resources/projects/javadoc/archetype.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
package=it.pkg.javadoc
version=0.1-SNAPSHOT
groupId=javadoc.archetype.it
artifactId=javadoc
grader=true
1 change: 1 addition & 0 deletions ...-parent/archetypes-parent/apptbook-archetype/src/test/resources/projects/javadoc/goal.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
javadoc:javadoc
13 changes: 13 additions & 0 deletions ...nt/archetypes-parent/apptbook-archetype/src/test/resources/projects/javadoc/verify.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
package projects.javadoc

File buildLog = new File(basedir, "project/javadoc/build.log");
if (!buildLog.isFile()) {
throw new FileNotFoundException("Couldn't find build log: " + buildLog)
}

String logText = buildLog.text

def expectedJavaDoc = "The main class for the CS410J appointment book Project"
if (!logText.contains(expectedJavaDoc)) {
throw new IllegalStateException("Didn't find expected JavaDoc: " + expectedJavaDoc)
}
4 changes: 4 additions & 0 deletions ...t/archetypes-parent/apptbook-gwt-archetype/src/main/resources/archetype-resources/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,9 @@
<profiles>
<profile>
<id>grader</id>
<activation>
<activeByDefault>${grader}</activeByDefault>
</activation>
<build>
<plugins>
<plugin>
Expand All @@ -211,6 +214,7 @@
<version>Summer2017</version>
</docletArtifact>
<useStandardDocletOptions>false</useStandardDocletOptions>
<show>private</show>
</configuration>
</plugin>
</plugins>
Expand Down
5 changes: 5 additions & 0 deletions ...es-parent/apptbook-gwt-archetype/src/test/resources/projects/javadoc/archetype.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
package=it.pkg.javadoc
version=0.1-SNAPSHOT
groupId=javadoc.archetype.it
artifactId=javadoc
grader=true
1 change: 1 addition & 0 deletions ...ent/archetypes-parent/apptbook-gwt-archetype/src/test/resources/projects/javadoc/goal.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
javadoc:javadoc
11 changes: 11 additions & 0 deletions ...rchetypes-parent/apptbook-gwt-archetype/src/test/resources/projects/javadoc/verify.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
File buildLog = new File(basedir, "project/javadoc/build.log");
if (!buildLog.isFile()) {
throw new FileNotFoundException("Couldn't find build log: " + buildLog)
}

String logText = buildLog.text

def expectedJavaDoc = "A basic GWT class that makes sure that we can send an appointment book"
if (!logText.contains(expectedJavaDoc)) {
throw new IllegalStateException("Didn't find expected JavaDoc: " + expectedJavaDoc)
}
4 changes: 4 additions & 0 deletions ...t/archetypes-parent/apptbook-web-archetype/src/main/resources/archetype-resources/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,9 @@
<profiles>
<profile>
<id>grader</id>
<activation>
<activeByDefault>${grader}</activeByDefault>
</activation>
<build>
<plugins>
<plugin>
Expand All @@ -202,6 +205,7 @@
<version>Summer2017</version>
</docletArtifact>
<useStandardDocletOptions>false</useStandardDocletOptions>
<show>private</show>
</configuration>
</plugin>
</plugins>
Expand Down
5 changes: 5 additions & 0 deletions ...es-parent/apptbook-web-archetype/src/test/resources/projects/javadoc/archetype.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
package=it.pkg.javadoc
version=0.1-SNAPSHOT
groupId=javadoc.archetype.it
artifactId=javadoc
grader=true
1 change: 1 addition & 0 deletions ...ent/archetypes-parent/apptbook-web-archetype/src/test/resources/projects/javadoc/goal.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
javadoc:javadoc
11 changes: 11 additions & 0 deletions ...rchetypes-parent/apptbook-web-archetype/src/test/resources/projects/javadoc/verify.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
File buildLog = new File(basedir, "project/javadoc/build.log");
if (!buildLog.isFile()) {
throw new FileNotFoundException("Couldn't find build log: " + buildLog)
}

String logText = buildLog.text

def expectedJavaDoc = "A helper class for accessing the rest client"
if (!logText.contains(expectedJavaDoc)) {
throw new IllegalStateException("Didn't find expected JavaDoc: " + expectedJavaDoc)
}
4 changes: 4 additions & 0 deletions ...rent/archetypes-parent/phonebill-archetype/src/main/resources/archetype-resources/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,9 @@
<profiles>
<profile>
<id>grader</id>
<activation>
<activeByDefault>${grader}</activeByDefault>
</activation>
<build>
<plugins>
<plugin>
Expand All @@ -136,6 +139,7 @@
<version>Summer2017</version>
</docletArtifact>
<useStandardDocletOptions>false</useStandardDocletOptions>
<show>private</show>
</configuration>
</plugin>
</plugins>
Expand Down
5 changes: 5 additions & 0 deletions ...types-parent/phonebill-archetype/src/test/resources/projects/javadoc/archetype.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
package=it.pkg.javadoc
version=0.1-SNAPSHOT
groupId=javadoc.archetype.it
artifactId=javadoc
grader=true
1 change: 1 addition & 0 deletions ...parent/archetypes-parent/phonebill-archetype/src/test/resources/projects/javadoc/goal.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
javadoc:javadoc
11 changes: 11 additions & 0 deletions ...t/archetypes-parent/phonebill-archetype/src/test/resources/projects/javadoc/verify.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
File buildLog = new File(basedir, "project/javadoc/build.log");
if (!buildLog.isFile()) {
throw new FileNotFoundException("Couldn't find build log: " + buildLog)
}

String logText = buildLog.text

def expectedJavaDoc = "The main class for the CS410J Phone Bill Project"
if (!logText.contains(expectedJavaDoc)) {
throw new IllegalStateException("Didn't find expected JavaDoc: " + expectedJavaDoc)
}
4 changes: 4 additions & 0 deletions .../archetypes-parent/phonebill-gwt-archetype/src/main/resources/archetype-resources/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,9 @@
<profiles>
<profile>
<id>grader</id>
<activation>
<activeByDefault>${grader}</activeByDefault>
</activation>
<build>
<plugins>
<plugin>
Expand All @@ -198,6 +201,7 @@
<version>Summer2017</version>
</docletArtifact>
<useStandardDocletOptions>false</useStandardDocletOptions>
<show>private</show>
</configuration>
</plugin>
</plugins>
Expand Down
5 changes: 5 additions & 0 deletions ...s-parent/phonebill-gwt-archetype/src/test/resources/projects/javadoc/archetype.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
package=it.pkg.javadoc
version=0.1-SNAPSHOT
groupId=javadoc.archetype.it
artifactId=javadoc
grader=true
1 change: 1 addition & 0 deletions ...nt/archetypes-parent/phonebill-gwt-archetype/src/test/resources/projects/javadoc/goal.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
javadoc:javadoc
11 changes: 11 additions & 0 deletions ...chetypes-parent/phonebill-gwt-archetype/src/test/resources/projects/javadoc/verify.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
File buildLog = new File(basedir, "project/javadoc/build.log");
if (!buildLog.isFile()) {
throw new FileNotFoundException("Couldn't find build log: " + buildLog)
}

String logText = buildLog.text

def expectedJavaDoc = "A basic GWT class that makes sure that we can send an Phone Bill back"
if (!logText.contains(expectedJavaDoc)) {
throw new IllegalStateException("Didn't find expected JavaDoc: " + expectedJavaDoc)
}
4 changes: 4 additions & 0 deletions .../archetypes-parent/phonebill-web-archetype/src/main/resources/archetype-resources/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,9 @@
<profiles>
<profile>
<id>grader</id>
<activation>
<activeByDefault>${grader}</activeByDefault>
</activation>
<build>
<plugins>
<plugin>
Expand All @@ -203,6 +206,7 @@
<version>Summer2017</version>
</docletArtifact>
<useStandardDocletOptions>false</useStandardDocletOptions>
<show>private</show>
</configuration>
</plugin>
</plugins>
Expand Down
5 changes: 5 additions & 0 deletions ...s-parent/phonebill-web-archetype/src/test/resources/projects/javadoc/archetype.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
package=it.pkg.javadoc
version=0.1-SNAPSHOT
groupId=javadoc.archetype.it
artifactId=javadoc
grader=true
1 change: 1 addition & 0 deletions ...nt/archetypes-parent/phonebill-web-archetype/src/test/resources/projects/javadoc/goal.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
javadoc:javadoc
11 changes: 11 additions & 0 deletions ...chetypes-parent/phonebill-web-archetype/src/test/resources/projects/javadoc/verify.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
File buildLog = new File(basedir, "project/javadoc/build.log");
if (!buildLog.isFile()) {
throw new FileNotFoundException("Couldn't find build log: " + buildLog)
}

String logText = buildLog.text

def expectedJavaDoc = "A helper class for accessing the rest client."
if (!logText.contains(expectedJavaDoc)) {
throw new IllegalStateException("Didn't find expected JavaDoc: " + expectedJavaDoc)
}
Loading