Skip to content

Warn about NBSP in formatted dates #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DavidWhitlock merged 1 commit into from
Jun 10, 2025
Merged

Warn about NBSP in formatted dates #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 26 additions & 26 deletions koans/app/config/PathToEnlightenment.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,32 +1,32 @@
<?xml version="1.0" encoding="ISO-8859-1"?>
<packages>
<package pkg="beginner" name="Novice">
<suite class="AboutKoans">
<koan name="findAboutKoansFile" displayIncompleteKoanException="false" />
<koan name="definitionOfKoanCompletion" displayIncompleteKoanException="false" />
</suite>
<suite class="AboutAssertions"/>
<suite class="AboutEquality"/>
<suite class="AboutStrings"/>
<suite class="AboutArithmeticOperators"/>
<suite class="AboutConditionals"/>
<suite class="AboutLoops" />
<suite class="AboutPrimitives" />
<suite class="AboutObjects"/>
<suite class="AboutInheritance"/>
<suite class="AboutCasting"/>
<suite class="AboutConstructors"/>
<suite class="AboutEnums"/>
<suite class="AboutExceptions"/>
<suite class="AboutMethodPreference"/>
<suite class="AboutBitwiseOperators"/>
<suite class="AboutArrays"/>
<suite class="AboutVarArgs"/>
</package>
<!-- <package pkg="beginner" name="Novice">-->
<!-- <suite class="AboutKoans">-->
<!-- <koan name="findAboutKoansFile" displayIncompleteKoanException="false" />-->
<!-- <koan name="definitionOfKoanCompletion" displayIncompleteKoanException="false" />-->
<!-- </suite>-->
<!-- <suite class="AboutAssertions"/>-->
<!-- <suite class="AboutEquality"/>-->
<!-- <suite class="AboutStrings"/>-->
<!-- <suite class="AboutArithmeticOperators"/>-->
<!-- <suite class="AboutConditionals"/>-->
<!-- <suite class="AboutLoops" />-->
<!-- <suite class="AboutPrimitives" />-->
<!-- <suite class="AboutObjects"/>-->
<!-- <suite class="AboutInheritance"/>-->
<!-- <suite class="AboutCasting"/>-->
<!-- <suite class="AboutConstructors"/>-->
<!-- <suite class="AboutEnums"/>-->
<!-- <suite class="AboutExceptions"/>-->
<!-- <suite class="AboutMethodPreference"/>-->
<!-- <suite class="AboutBitwiseOperators"/>-->
<!-- <suite class="AboutArrays"/>-->
<!-- <suite class="AboutVarArgs"/>-->
<!-- </package>-->
<package pkg="intermediate" name="Intermediate">
<suite class="AboutAutoboxing"/>
<suite class="AboutCollections"/>
<suite class="AboutComparison"/>
<!-- <suite class="AboutAutoboxing"/>-->
<!-- <suite class="AboutCollections"/>-->
<!-- <suite class="AboutComparison"/>-->
<suite class="AboutDates"/>
<suite class="AboutEquality"/>
<suite class="AboutFileIO"/>
Expand Down
3 changes: 2 additions & 1 deletion koans/src/intermediate/AboutDates.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

public class AboutDates {

private LocalDateTime date = LocalDateTime.ofInstant(Instant.ofEpochMilli(100010001000L), ZoneId.systemDefault());
private LocalDateTime date = LocalDateTime.ofInstant(Instant.ofEpochMilli(100010001000L), ZoneId.of("-07:00"));

@Koan
public void dateToString() {
Expand All @@ -42,6 +42,7 @@ public void usingDateTimeFormatterToFormatDate() {

@Koan
public void usingDateTimeFormatterToFormatDateShort() {
// Careful, formatted dates may contain non-breaking spaces!
String formattedDate = DateTimeFormatter.ofLocalizedDateTime(FormatStyle.SHORT).format(date);
assertEquals(formattedDate, __);
}
Expand Down