💹 Fix chunk sizes #4580
Merged
💹 Fix chunk sizes #4580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attemka
approved these changes
Aug 7, 2023
| @@ -108,12 +108,14 @@ export const MainLayout: FC = () => { | |||
| return ( | |||
| <> | |||
| <CookiePopover /> | |||
| {/*<Suspense fallback={<div>adawd</div>}>*/} | |||
There was a problem hiding this comment.
suspense will be included when it'll be supported by apollo client
There was a problem hiding this comment.
This should be deleted, since I introduced it in Viewer and Studio layout
| @@ -35,3 +35,5 @@ export const StudioEntrypoint: FC<StudioEntrypointProps> = ({ enterLocation }) = | |||
|
|
|||
| return <StudioLoading /> | |||
| } | |||
|
|
|||
| export default StudioEntrypoint | |||
There was a problem hiding this comment.
we should't change it in this PR, but generally we should avoid default export in files
There was a problem hiding this comment.
React.lazy requires default export
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4575