Merge pull request #4757 from Lezek123/argus-fix-cache-drop

Argus fix: Cache cleanup not working properly for objects in group `0`
Joystream · May 16, 2023 · 36eeb20 · 36eeb20
2 parents efd2940 + c66ca38
commit 36eeb20
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/distributor-node/CHANGELOG.md b/distributor-node/CHANGELOG.md
@@ -1,6 +1,7 @@
 ### 1.2.0
 
 - Add support for Elasticsearch authentication (`logs.elastic.auth` config section)
+- **FIX:** Objects belonging to group `0` of LRU-SP cache were never fully dropped from the state because of a bug in `StateCacheService.dropById`
 
 ### 1.1.0 (Ephesus release)
 

diff --git a/distributor-node/src/services/cache/StateCacheService.ts b/distributor-node/src/services/cache/StateCacheService.ts
@@ -182,7 +182,7 @@ export class StateCacheService {
     this.dropPendingDownload(objectId)
     const cacheGroupNumber = this.memoryState.groupNumberByObjectId.get(objectId)
     this.logger.debug('Cache group by object id established', { objectId, cacheGroupNumber })
-    if (cacheGroupNumber) {
+    if (cacheGroupNumber !== undefined) {
       this.memoryState.groupNumberByObjectId.delete(objectId)
       this.storedState.lruCacheGroups[cacheGroupNumber].delete(objectId)
     }