Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Colossus] handle aborted uploads #4777

Merged
merged 6 commits into from
Jun 8, 2023
Merged

[Colossus] handle aborted uploads #4777

merged 6 commits into from
Jun 8, 2023

Conversation

mnaamani
Copy link
Member

Fixes #4773

@vercel
Copy link

vercel bot commented May 31, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
pioneer-testnet ⬜️ Ignored (Inspect) Jun 1, 2023 4:09pm

@mnaamani mnaamani requested a review from zeeshanakram3 June 1, 2023 06:23
@mnaamani mnaamani marked this pull request as ready for review June 1, 2023 06:23
zeeshanakram3
zeeshanakram3 approved these changes Jun 4, 2023
View reviewed changes
Copy link
Contributor

@zeeshanakram3 zeeshanakram3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this fix locally. LGTM

@mnaamani mnaamani merged commit 895ed9e into Joystream:master Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeeshanakram3 zeeshanakram3 zeeshanakram3 approved these changes

Assignees
No one assigned
Labels
colossus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Colossus] Handle temp file cleanup on failed upload
2 participants
@mnaamani @zeeshanakram3