Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow certificates managed by the companion with a dot file #472

Merged
merged 3 commits into from
Nov 23, 2018

Conversation

buchdag
Copy link
Member

@buchdag buchdag commented Nov 23, 2018

As discussed in #465, this PR should fix the remaining issues with hybrid configurations (certs obtained through the companion stored and used along certs obtained another way).

[...] include a dot file next to the certs handled by the companion during creation / renewal (most importantly before the symlink cleanup function). Then the symlink cleanup function check for the presence of this dot file. If it's not there, those files are not handled by the companion, don't touch the symlinks.

@ejbp any thought before merging this ?

@ejbp
Copy link

ejbp commented Nov 23, 2018

@buchdag It looks very nice. I've nothing further to add. Thanks for the update 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature-request Issue requesting a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants