fixed the test for has_one without included data #244
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsmestad
added a commit
to jsmestad/jsonapi-consumer
that referenced
this pull request
Apr 13, 2018
Thanks @JohnSmall for the original [PR #244](JsonApiClient/json_api_client#244)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to issues #226 and #218 where we get an error on has one relationship if the JSON response has data in the relationships section, but nothing is included.
There was a faulty test for 'has_one' without included data, had included data and therefore passed when it should have failed.
When I modified the test so that it didn't have included data, then it failed as it should have done.
Then I changed the code to make the test pass. If the JSON package has data in the relationships, but nothing in the included data, then it uses the information in the data section to get the record pointed to by the has_one relationship.