-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for faraday 2.x #412
Conversation
@gaorlov Bump please :) Faraday 2.0 has been out for almost 2 years. |
@gaorlov Is this still being considered? My team depends heavily |
Hi, folks! |
I don't remember making a conscious decision to remove those. Looking at the commit, it looks live it was auto-removed when running the appraisal generator. Is it possible that those are obsolete files? |
i must admit i am not up to date on rails versions. It looks like 6.0 has reached EOL, but 6.1 is still supported. Can we bring it back and just test against |
is there another mechanism by which we test that activesupport version? also: looks like there's a bunch of old ruby failures. i think it's probably okay to drop ruby 2.3, 2.4, and 2.5 from the test matrix if you want to drop them from the workflow |
5c875cf
to
1eb9bc9
Compare
New matrix:
Updated the changelog as well |
- ruby: "2.7" | ||
rails: "4.2" | ||
ruby: | ||
- "3.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be quoted, otherwise 3.0
becomes 3
, which gets interpreted as 3.x
, resolving to 3.3
marvelous. thank you for pulling in |
Oddly enough, it was there as a dependency and the configurations were there, but it wasn't being used in the tests 🤷🏼♂️ |
thank you for you contributions and patience! |
Includes a rebased version of #402
Fixes #407
ParseJson
middlewareNotice how no tests have changed