Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v2.3.0 #169

Merged
merged 52 commits into from
Nov 28, 2024
Merged

Release v2.3.0 #169

merged 52 commits into from
Nov 28, 2024

Conversation

PhilippRue
Copy link
Member

@PhilippRue PhilippRue commented Nov 28, 2024

Release v2.3.0

Description of important changes

  • add STM scanning workflow
  • left/right continuation in decimation workflow
  • truncate long node labels (can't be stored if too long)
  • wfac_renorm in host -> use automatically in KKRimp
  • improved test coverage & modernization of caching
  • minor bugfixes

Checklist for next release

  • finish your development and merge it into the develop branch
  • update documentation
  • update / fix tests
  • bump version numbers (in files aiida_kkr/__init__.py, pyproject.toml, .bumpversion.cfg)

If everything is done, you can merge your changes from develop back into master and create a tag for the new version number. Creating a new tag always triggers publication to pypi (see .github/workflows/cd.yml for the definition of this github action).

Raff-physics and others added 30 commits March 8, 2024 16:27
- Allow to set energy range from input
- Fix input of 'retrieve_kkrflex'
- Cleanup in workflow
- Fix error where process gets stuck due to label being too long (255 max numbe rof chars)
- Add possibility to use custom scanning positions via 'scan_positions' entry in 'tip_position' input dict
- allow to set shapefun in voronoi calculation from input
- set kkrflex_llyfac from wfac_renorm
- minor bugfix in gf_writeout which can now also start from a voronoi run
…he correct np.array format if the key 'imp_cls' was alreday present
…ctly use the 'noco_angles' and assign these angles for the vacuum sites. Also a robustness update was made

if the imp info is already in the cls format it is able to work with that
Raff-physics and others added 21 commits October 2, 2024 19:48
- fix offset position (removed modulo 1 in `tools/tools_STM_scan.py`->`get_r_offset`)
- removed code duplication by `self.get_tip_position_dict(da, db)` in `workflows/kkr_STM.py`
- corrected confusing names of functions (combine_potentials`->`combine_imp_info` and `combine_nodes`->`combine_potentials`)
- corrected deduplication checking of cluster positions (`pos_exists_already` needed `clust_offset` input instead of position without layer offset)
…ew version of a helper function in the kkr_STM
- take care of edge case where Zimp is not a list but a number (happens for single impurity case without specification of imp_cls input)
- fix renaming params_kkr_overwrite -> params_overwrite
Update to latest released version
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 69.87952% with 150 lines in your changes missing coverage. Please review.

Project coverage is 68.51%. Comparing base (3144c3a) to head (35daa62).
Report is 54 commits behind head on master.

Files with missing lines Patch % Lines
aiida_kkr/workflows/_decimation.py 39.60% 61 Missing ⚠️
aiida_kkr/workflows/kkr_STM.py 43.28% 38 Missing ⚠️
aiida_kkr/calculations/kkrimp.py 23.52% 13 Missing ⚠️
aiida_kkr/workflows/gf_writeout.py 44.44% 10 Missing ⚠️
aiida_kkr/tools/imp_cluster_tools.py 20.00% 8 Missing ⚠️
aiida_kkr/tools/tools_STM_scan.py 87.69% 8 Missing ⚠️
aiida_kkr/workflows/kkr_imp_sub.py 75.00% 6 Missing ⚠️
aiida_kkr/calculations/kkr.py 33.33% 2 Missing ⚠️
aiida_kkr/workflows/kkr_imp_dos.py 75.00% 2 Missing ⚠️
aiida_kkr/parsers/kkrimp.py 91.66% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #169      +/-   ##
==========================================
+ Coverage   59.41%   68.51%   +9.10%     
==========================================
  Files         102      104       +2     
  Lines       14606    14850     +244     
==========================================
+ Hits         8678    10175    +1497     
+ Misses       5928     4675    -1253     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PhilippRue PhilippRue merged commit 409e233 into master Nov 28, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants