Proper Android 10 support #36
Conversation
# Conflicts: # android/src/main/java/com/reactlibrary/rnwifi/RNWifiModule.java
|
I really like this PR and appreciate your work. However, as discussed in ThanosFisherman/WifiUtils#47, WifiUtils Android 10 compatibility has not been properly tested. @eliaslecomte, have you tested this changes on a real Android device? |
| /** | ||
| * Send the SSID and password of a Wifi network into this to connect to the network. | ||
| * Example: wifi.findAndConnect(ssid, password); | ||
| * After 10 seconds, a post telling you whether you are connected will pop up. | ||
| * Callback returns true if ssid is in the range | ||
| * Use this to connect with a wifi network. | ||
| * Example: wifi.findAndConnect(ssid, password, false); | ||
| * The promise will resolve with the message 'connected' when the user is connected on Android. | ||
| * | ||
| * @param SSID name of the network to connect with | ||
| * @param password password of the network to connect with | ||
| * @param isWep required for iOS | ||
| * @param promise | ||
| * @param isWep only for iOS | ||
| * @param promise to send success/error feedback | ||
| */ | ||
| @ReactMethod | ||
| public void connectToProtectedSSID(@NonNull final String SSID, @NonNull final String password, final boolean isWep, final Promise promise) { |
There was a problem hiding this comment.
If this method is now compatible with open WiFi networks, we should document it.
There was a problem hiding this comment.
I assume on Android you could always connect to an open network with using an empty string as password. In my opinition we should also have the same connectTo methods on iOS and Android.
|
I agree more testing should be done. Specially edge cases. I have tested the happy flow on a Pixel 4. |
|
@eliaslecomte, if someone uses this module to connect a network indefinitely, does this PR break that functionality? |
I fear for it. I don't see how with the changes for Android 10. |
|
@eliaslecomte, while this module targets API 28, it will still work on Android 10. I am currently using it on my personal device on Android 10. The option 2 from your original comment looks more like the scope of this project. The module suggest a network and user decides to connect. This is how iOS handles the connections at the moment. |
I'll will go through the change requests on thursday. |
Problem is that even when targetting sdk 28 it won't work on all Android 10 devices. For example it doesn't work on the Samsung s10. |
|
I've opened a new PR as I didn't want to rewrite all of the history here (changing commit messages..); #46 |
Starting Android 10, it's no longer possible to connect (as an app) to wifi networks like before.
What can an app still do:
With this PR, i've switched the connection logic to use WifiUtils which just released support for option 1.
Advantages of using WifiUtils: