Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Examples to 'Examples' page #25

Merged
merged 4 commits into from
Feb 7, 2024

Conversation

GrandeMan
Copy link
Contributor

@GrandeMan GrandeMan commented Feb 6, 2024

-Create Example component and routes to App.jsx

-Create demo vid and embed in Examples.jsx

-Add generated cover letters to Examples.jsx

-Add breakpoints and adhere to style of other pages

-Build and test

Description

Create demo vid and cover letter examples

Checklist

  • I have read the CONTRIBUTING.md document.
  • My code follows the coding guidelines of the project.
  • I have tested my changes thoroughly.
  • I have added/updated relevant documentation.
  • I have updated any necessary unit tests.
  • My commits follow the commit guidelines.

Fixes #4

-Create Example component and routes to App.jsx

-Create demo vid and embed in Examples.jsx

-Add generated cover letters to Examples.jsx

-Add breakpoints and adhere to style of other pages

-Build and test
Copy link

vercel bot commented Feb 6, 2024

Someone is attempting to deploy a commit to a Personal Account owned by @Judge-Paul on Vercel.

@Judge-Paul first needs to authorize it.

Copy link

vercel bot commented Feb 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
coverwrite-ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2024 9:14pm

@Judge-Paul
Copy link
Owner

@GrandeMan Please check the review and make the necessary changes so I can merge

Everything else looks good and thanks for your contribution.

GrandeMan

This comment was marked as duplicate.

Copy link
Contributor Author

@GrandeMan GrandeMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@Judge-Paul
Copy link
Owner

You haven't made any new commits yet

@GrandeMan
Copy link
Contributor Author

Sorry about that, I was having a problem with my prettier config. Should've just edited the code here (Github) from the beginning. The files should be good now

Copy link
Owner

@Judge-Paul Judge-Paul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but your tabs configuration is affecting the App,jsx file and adding more spaces than it should.

If you want to use those spaces in the page you created that's fine but please leave the App.jsx to default formatting

@Judge-Paul Judge-Paul merged commit af6d69a into Judge-Paul:main Feb 7, 2024
1 check failed
@Judge-Paul
Copy link
Owner

@GrandeMan I saw the video when I was reviewing it but I didn't play it cause I thought it was just a no-audio recording of you using the site, but it's really impressive, sorry I didn't notice it sooner

Thanks a lot 🙏🏾

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create examples
2 participants