-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Examples to 'Examples' page #25
Conversation
-Create Example component and routes to App.jsx -Create demo vid and embed in Examples.jsx -Add generated cover letters to Examples.jsx -Add breakpoints and adhere to style of other pages -Build and test
Someone is attempting to deploy a commit to a Personal Account owned by @Judge-Paul on Vercel. @Judge-Paul first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@GrandeMan Please check the review and make the necessary changes so I can merge Everything else looks good and thanks for your contribution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go
You haven't made any new commits yet |
Sorry about that, I was having a problem with my prettier config. Should've just edited the code here (Github) from the beginning. The files should be good now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but your tabs configuration is affecting the App,jsx file and adding more spaces than it should.
If you want to use those spaces in the page you created that's fine but please leave the App.jsx to default formatting
@GrandeMan I saw the video when I was reviewing it but I didn't play it cause I thought it was just a no-audio recording of you using the site, but it's really impressive, sorry I didn't notice it sooner Thanks a lot 🙏🏾 |
-Create Example component and routes to App.jsx
-Create demo vid and embed in Examples.jsx
-Add generated cover letters to Examples.jsx
-Add breakpoints and adhere to style of other pages
-Build and test
Description
Create demo vid and cover letter examples
Checklist
Fixes #4