Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polymer.js not first script tag #1

Closed
matthiasg opened this issue Jun 30, 2014 · 5 comments
Closed

polymer.js not first script tag #1

matthiasg opened this issue Jun 30, 2014 · 5 comments

Comments

@matthiasg
Copy link

polymer is complaining that it isnt the first script in the kitchen sink demo... that might be a reason its not working in IE11 (stable and dev) ..

since i am testing/evaluating compatibility of polymer as compared to angular did you do that intentionally ?

cheers (nice work btw)

@tomalec
Copy link
Member

tomalec commented Jun 30, 2014

Thanks @matthiasg :) and thanks for the feedback.

I was not able to reproduce polymer's complain you mentioned. However I moved platform.js script tag, to the top in kitchen-sink.html. Have you faced this issue there, or also in index.html (where it already is the first import)?

Regarding IE, the problem is with shimming ::content selector in element's <template>. I tried polyfill-next-selector but for some reason it does not work, I will investigate it further.

Is it an urgent need? If so I could make a quick workaround, by applying inline styles for div#juicy-ace-editor-container.

@matthiasg
Copy link
Author

Thanks for that.. I am evaluating to move some of our
external components from angular to web components for better separation. Polymer looks like it's on a good track but we need to support ie11 upwards that's why I was looking at your component. Right now we wrapped ace in angular .. Works fine of course but web components have some obvious long term benefits for us.

The error message about the script appeared in ie11 standard and dev channel on the console.

I tried only the main page of the kitchen sink.

I would really like to know if ie it's inherently stake out unstable with polymer.. I might look into your code more deeply in the next few days..

Thanks

-----Original Message-----
From: "Tomek Wytrębowicz" notifications@github.com
Sent: ‎30.‎06.‎2014 20:53
To: "Juicy/juicy-ace-editor" juicy-ace-editor@noreply.github.com
Cc: "matthiasg" mgt576@gmail.com
Subject: Re: [juicy-ace-editor] polymer.js not first script tag (#1)

Thanks @matthiasg :) and thanks for the feedback.
I was not able to reproduce polymer's complain you mentioned. However I moved platform.js script tag, to the top in kitchen-sink.html. Have you faced this issue there, or also in index.html (where it already is the first import)?
Regarding IE, the problem is with shimming ::content selector in element's . I tried polyfill-next-selector but for some reason it does not work, I will investigate it further.
Is it an urgent need? If so I could make a quick workaround, by applying inline styles for div#juicy-ace-editor-container.

Reply to this email directly or view it on GitHub.

@tomalec
Copy link
Member

tomalec commented Jun 30, 2014

Hmm.. that's strange, as I cannot see any error in my IE11. Have you used tagged version or HEAD (bower install juicy-ace-editor#gh-pages --save)?

Polymer should support IE10+ http://www.polymer-project.org/resources/compatibility.html
As for now (6 months playing with Polymer full-time) I have not faced any bigger issues with Web Components Polyfill in IE.
Hopefully this one is something easy to fix either on my or on Polymer's side (Polymer/polymer#582).

@tomalec
Copy link
Member

tomalec commented Jun 30, 2014

So here you have the fix :) It was my bad.

All this manual work around CSS shim would not be needed if I would use <polymer-element> but I try to stick to 🍦 VanillaJS as much as I can for independence, performance, and learning reasons ;)

@matthiasg
Copy link
Author

Great ! Thanks ... I will try asap .. Also I will look at your code more in detail .. I like that you try to stay vanilla for now..

-----Original Message-----
From: "Tomek Wytrębowicz" notifications@github.com
Sent: ‎30.‎06.‎2014 21:50
To: "Juicy/juicy-ace-editor" juicy-ace-editor@noreply.github.com
Cc: "matthiasg" mgt576@gmail.com
Subject: Re: [juicy-ace-editor] polymer.js not first script tag (#1)

So here you have the fix :) It was my bad.
All this manual work around CSS shim would not be needed if I would use but I try to stick to VanillaJS as much as I can for independence, performance, and learning reasons ;)

Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants