Do not issue request for undefined hrefs

Juicy · Nov 27, 2017 · 7fbd1f5 · 7fbd1f5
1 parent 06976df
commit 7fbd1f5
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/juicy-html.html b/juicy-html.html
@@ -55,7 +55,7 @@
                 },
                 'href': {
                     set: function(newValue) {
-                        if(newValue === null){
+                        if(newValue === null || newValue === undefined){
                             this.removeAttribute('href');
                         } else {
                             this.setAttribute('href', newValue);
@@ -67,7 +67,7 @@
                 },
                 'html': {
                     set: function(newValue) {
-                        if(newValue === null){
+                        if(newValue === null || newValue === undefined){
                             this.removeAttribute('html');
                         } else {
                             this.setAttribute('html', newValue);

diff --git a/test/skipping.html b/test/skipping.html
@@ -86,6 +86,14 @@
                     expect(myEl.skipStampingPendingFile).not.to.be.called;
                 });
             });
+            describe("Undefined URL", function() {
+                it("It shouldn't issue a request if URL is undefined", function() {
+                    myEl = fixture('juicy-html-fixture').querySelector('template[is="juicy-html"]');
+                    sinon.spy(myEl, '_loadExternalFile');
+                    myEl.href = undefined;
+                    expect(myEl._loadExternalFile).not.to.be.called;
+                });
+            });
         });
     </script>