Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make variational refs elide AD buffering #260

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Make variational refs elide AD buffering #260

merged 2 commits into from
Jul 23, 2024

Conversation

miguelbiron
Copy link
Collaborator

Reasoning:

  1. Variational refs usually have analytic gradients anyway
  2. It can be challenging to distinguish between the proper reference and the variational reference in the buffering system, especially since the var ref is not activated immediately.

Closes #259

@miguelbiron miguelbiron merged commit 1de9c70 into main Jul 23, 2024
9 of 10 checks passed
@miguelbiron miguelbiron deleted the fix-259 branch July 23, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandrebouchard alexandrebouchard Awaiting requested review from alexandrebouchard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Method ambiguity introduced on latest release
1 participant
@miguelbiron