Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segfault fix #30

Merged
merged 65 commits into from
Mar 13, 2023
Merged

Segfault fix #30

merged 65 commits into from
Mar 13, 2023

Commits on Mar 6, 2023

  1. Configuration menu
    Copy the full SHA
    23b59d3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    40001d0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ff5aac9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d00ff53 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    69bb270 View commit details
    Browse the repository at this point in the history
  6. Revert "More conservative tag ub?"

    This reverts commit 69bb270.
    alexandrebouchard committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    d94252f View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    bcf016d View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2023

  1. Configuration menu
    Copy the full SHA
    379df4b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2cd3571 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c8a0261 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2023

  1. Candidate fix

    alexandrebouchard committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    6217650 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1f16936 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0ca198f View commit details
    Browse the repository at this point in the history
  4. Another free

    alexandrebouchard committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    ee276fc View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    491c26b View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2023

  1. system MPI test

    miguelbiron committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    fab7934 View commit details
    Browse the repository at this point in the history
  2. fix typos

    miguelbiron committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    2ed0aae View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c271261 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e3f569a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    77824ea View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c69b76a View commit details
    Browse the repository at this point in the history
  7. add missing env

    miguelbiron committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    523f9c1 View commit details
    Browse the repository at this point in the history
  8. another try

    miguelbiron committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    949b628 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    895a45f View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    13c9cd2 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    1772d82 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    bdf71ce View commit details
    Browse the repository at this point in the history
  13. new approach

    miguelbiron committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    2bcd825 View commit details
    Browse the repository at this point in the history
  14. Changing approach for Isend/isend: explicit Waitall for all requests

    A crash seemed to occur in CI during garbage collection
    
    julia:3364 terminated with signal 11 at PC=7f997aaec971 SP=7f9936ccb970.  Backtrace:
    /opt/hostedtoolcache/julia/1.8.5/x64/bin/../lib/julia/libjulia-internal.so.1(ijl_gc_safepoint+0x11)[0x7f997aaec971]
    
    This looks like a crash during garbage collection code (this would be consistent with the fact that it only shows up with allocation-heavy test, i.e. Turing).
    
    So even though the finalizer checks first before calling free, maybe there is something flaky there.
    
    #30 (comment)
    alexandrebouchard committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    eadbfcd View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    57d0921 View commit details
    Browse the repository at this point in the history
  16. Testing single-thread for all

    Multi-threading issue seems not specific to Turing as crash occurred
    for Blang in last commit.
    alexandrebouchard committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    63aad97 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    7a8de7e View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    5812127 View commit details
    Browse the repository at this point in the history
  19. openmpi_jll test

    miguelbiron committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    270333f View commit details
    Browse the repository at this point in the history
  20. openmpi_jll test

    miguelbiron committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    2b49008 View commit details
    Browse the repository at this point in the history
  21. openmpi_jll test

    miguelbiron committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    9c6497f View commit details
    Browse the repository at this point in the history
  22. openmpi_jll test

    miguelbiron committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    d68dc6c View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    38de7cf View commit details
    Browse the repository at this point in the history
  24. extra arg to OpenMPI

    miguelbiron committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    8537307 View commit details
    Browse the repository at this point in the history
  25. rm mpi version query

    miguelbiron committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    c2b732b View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    0e82a84 View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    82a4210 View commit details
    Browse the repository at this point in the history
  28. simplify logging

    miguelbiron committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    700c712 View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    ebcb3a6 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2023

  1. Configuration menu
    Copy the full SHA
    ad69b34 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6bde8fe View commit details
    Browse the repository at this point in the history
  3. Fix

    alexandrebouchard committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    7b5e7d4 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    fc34b85 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5ba839e View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    2b37c0f View commit details
    Browse the repository at this point in the history
  7. Fix last commit

    alexandrebouchard committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    0847901 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    f75a280 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    93033fc View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    d46d429 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    7a11074 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    d89911a View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2023

  1. Configuration menu
    Copy the full SHA
    aa233e8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    42993fd View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    42bdd75 View commit details
    Browse the repository at this point in the history
  4. mpiexec_args is a Cmd now

    miguelbiron committed Mar 11, 2023
    Configuration menu
    Copy the full SHA
    c5cb70a View commit details
    Browse the repository at this point in the history
  5. re-instate all tests

    miguelbiron committed Mar 11, 2023
    Configuration menu
    Copy the full SHA
    9e31b49 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    74a4355 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    7454ae9 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2023

  1. adding back all test

    miguelbiron committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    18ef655 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2023

  1. Change mpi_active impl to fix open mpi bug

    Before this, we had crashed such as in
    18ef655
    
    Here is what was happening in these crash
    1. parent process is using a system library
    2. parent process' test first call local pigeons
    3. that in turns called mpi_active() which internally used MPI.Init()
       to see if Comm_size > 1
    4. that had the side effect of changing ENV
    5. then, when calling pigeons MPI tests, these ENV variables were
       passed to ChildProcess, causing problems
    
    The new approach avoids to call MPI.Init() frivolously
    alexandrebouchard committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    b9c34d9 View commit details
    Browse the repository at this point in the history