Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation generation #26

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Fix documentation generation #26

merged 2 commits into from
Nov 28, 2023

Conversation

ablaom
Copy link
Member

@ablaom ablaom commented Nov 28, 2023

No description provided.

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (986192e) 64.70% compared to head (562f67a) 64.70%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev      #26   +/-   ##
=======================================
  Coverage   64.70%   64.70%           
=======================================
  Files           9        9           
  Lines         119      119           
=======================================
  Hits           77       77           
  Misses         42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ablaom
Copy link
Member Author

ablaom commented Nov 28, 2023

I don't understand this fail. It has something to do with my attempt to use the new Documenter.Remotes business. Here is the stack trace from the CI log:

ERROR: LoadError: MethodError: no method matching occursin(::String, ::Documenter.Remotes.GitHub)
[357](https://github.com/JuliaAI/LearnAPI.jl/actions/runs/7012923047/job/19078248635?pr=26#step:5:361)

[358](https://github.com/JuliaAI/LearnAPI.jl/actions/runs/7012923047/job/19078248635?pr=26#step:5:362)
Closest candidates are:
[359](https://github.com/JuliaAI/LearnAPI.jl/actions/runs/7012923047/job/19078248635?pr=26#step:5:363)
  occursin(::Union{AbstractChar, AbstractString}, ::AbstractString)
[360](https://github.com/JuliaAI/LearnAPI.jl/actions/runs/7012923047/job/19078248635?pr=26#step:5:364)
   @ Base strings/search.jl:699
[361](https://github.com/JuliaAI/LearnAPI.jl/actions/runs/7012923047/job/19078248635?pr=26#step:5:365)
  occursin(::Any)
[362](https://github.com/JuliaAI/LearnAPI.jl/actions/runs/7012923047/job/19078248635?pr=26#step:5:366)
   @ Base strings/search.jl:713
[363](https://github.com/JuliaAI/LearnAPI.jl/actions/runs/7012923047/job/19078248635?pr=26#step:5:367)

[364](https://github.com/JuliaAI/LearnAPI.jl/actions/runs/7012923047/job/19078248635?pr=26#step:5:368)
Stacktrace:
[365](https://github.com/JuliaAI/LearnAPI.jl/actions/runs/7012923047/job/19078248635?pr=26#step:5:369)
 [1] deploy_folder(cfg::Documenter.GitHubActions; repo::Documenter.Remotes.GitHub, repo_previews::Documenter.Remotes.GitHub, branch::String, branch_previews::String, devbranch::String, push_preview::Bool, devurl::String, tag_prefix::String, kwargs::Base.Pairs{Symbol, Union{}, Tuple{}, NamedTuple{(), Tuple{}}})
[366](https://github.com/JuliaAI/LearnAPI.jl/actions/runs/7012923047/job/19078248635?pr=26#step:5:370)
   @ Documenter ~/.julia/packages/Documenter/nQAq5/src/deployconfig.jl:328
[367](https://github.com/JuliaAI/LearnAPI.jl/actions/runs/7012923047/job/19078248635?pr=26#step:5:371)
 [2] deploydocs(; root::String, target::String, dirname::String, repo::Documenter.Remotes.GitHub, branch::String, repo_previews::Documenter.Remotes.GitHub, branch_previews::String, deps::Nothing, make::Nothing, devbranch::String, devurl::String, versions::Vector{Any}, forcepush::Bool, deploy_config::Documenter.GitHubActions, push_preview::Bool, tag_prefix::String, archive::Nothing)
[368](https://github.com/JuliaAI/LearnAPI.jl/actions/runs/7012923047/job/19078248635?pr=26#step:5:372)
   @ Documenter ~/.julia/packages/Documenter/nQAq5/src/deploydocs.jl:213
[369](https://github.com/JuliaAI/LearnAPI.jl/actions/runs/7012923047/job/19078248635?pr=26#step:5:373)
 [3] top-level scope
[370](https://github.com/JuliaAI/LearnAPI.jl/actions/runs/7012923047/job/19078248635?pr=26#step:5:374)
   @ ~/work/LearnAPI.jl/LearnAPI.jl/docs/make.jl:29
[371](https://github.com/JuliaAI/LearnAPI.jl/actions/runs/7012923047/job/19078248635?pr=26#step:5:375)
 [4] include(fname::String)
[372](https://github.com/JuliaAI/LearnAPI.jl/actions/runs/7012923047/job/19078248635?pr=26#step:5:376)
   @ Base.MainInclude ./client.jl:478
[373](https://github.com/JuliaAI/LearnAPI.jl/actions/runs/7012923047/job/19078248635?pr=26#step:5:377)
 [5] top-level scope
[374](https://github.com/JuliaAI/LearnAPI.jl/actions/runs/7012923047/job/19078248635?pr=26#step:5:378)
   @ none:8
[375](https://github.com/JuliaAI/LearnAPI.jl/actions/runs/7012923047/job/19078248635?pr=26#step:5:379)
in expression starting at /home/runner/work/LearnAPI.jl/LearnAPI.jl/docs/make.jl:29
[376](https://github.com/JuliaAI/LearnAPI.jl/actions/runs/7012923047/job/19078248635?pr=26#step:5:380)
Error: Process completed with exit code 1.

And here's the offending line in my make.jl file.

@ablaom ablaom merged commit 48c91eb into dev Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant