Merge pull request #917 from JuliaAI/patch-for-static-in-learning-net…

…works

Fix signature in operation overloadings for machines

src/machines.jl

@@ -533,7 +533,7 @@ last_model(mach) = isdefined(mach, :old_model) ? mach.old_model : nothing
         rows=nothing,
         verbosity=1,
         force=false,
-        composite=nothing
+        composite=nothing,
     )
 
 Without mutating any other machine on which it may depend, perform one of the following
@@ -553,7 +553,7 @@ data to `rows` if specified:
    increment `mach.state`.
 
 If the model, `model`, bound to `mach` is a symbol, then instead perform the action using
-the true model `getproperty(composite, model)`.
+the true model given by `getproperty(composite, model)`. See also [`machine`](@ref).
 
 
 ### Training action logic
@@ -762,13 +762,13 @@ end
 
 """
 
-    fit!(mach::Machine, rows=nothing, verbosity=1, force=false)
+    fit!(mach::Machine, rows=nothing, verbosity=1, force=false, composite=nothing)
 
 Fit the machine `mach`. In the case that `mach` has `Node` arguments,
 first train all other machines on which `mach` depends.
 
 To attempt to fit a machine without touching any other machine, use
-`fit_only!`. For more on the internal logic of fitting see
+`fit_only!`. For more on options and the the internal logic of fitting see
 [`fit_only!`](@ref)
 
 """

src/operations.jl

@@ -138,7 +138,7 @@ for operation in OPERATIONS
             get!(ret, $quoted_operation, mach)
         end
 
-        function $operation(mach::Machine{<:Static}, Xraw, Xraw_more...)
+        function $operation(mach::Machine, Xraw, Xraw_more...)
             _check_and_fit_if_warranted!(mach)
             ret = $(operation)(
                 last_model(mach),
@@ -153,10 +153,11 @@ for operation in OPERATIONS
         $operation(mach::Machine, X::AbstractNode) =
             node($(operation), mach, X)
 
-        $operation(mach::Machine{<:Static},
-                   X::AbstractNode,
-                   Xmore::AbstractNode...) =
-                       node($(operation), mach, X, Xmore...)
+        $operation(
+            mach::Machine,
+            X::AbstractNode,
+            Xmore::AbstractNode...,
+        ) = node($(operation), mach, X, Xmore...)
     end
     eval(ex)
 end