Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a minor check to the arguments of range #426

Merged
merged 1 commit into from
Sep 11, 2020
Merged

Add a minor check to the arguments of range #426

merged 1 commit into from
Sep 11, 2020

Conversation

ablaom
Copy link
Member

@ablaom ablaom commented Sep 11, 2020

Improves the range doc-string and adds a check that at least one of the following keywords is specified: [values, lower, upper, origin, unit].

@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2020

Codecov Report

Merging #426 into dev will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #426      +/-   ##
==========================================
- Coverage   81.83%   81.80%   -0.04%     
==========================================
  Files          38       38              
  Lines        2703     2704       +1     
==========================================
  Hits         2212     2212              
- Misses        491      492       +1     
Impacted Files Coverage Δ
src/hyperparam/one_dimensional_ranges.jl 80.76% <100.00%> (-1.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a4920c...95b3c32. Read the comment docs.

@ablaom ablaom merged commit 2cb4eac into dev Sep 11, 2020
@DilumAluthge DilumAluthge deleted the range-checks branch January 23, 2022 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants