Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #14 for Julia 0.6 #25

Merged
merged 1 commit into from
Jun 20, 2018
Merged

Revert #14 for Julia 0.6 #25

merged 1 commit into from
Jun 20, 2018

Conversation

saschatimme
Copy link
Contributor

This reverts #14 for Julia 0.6 to adress #18. This is not really satisfactory, but I would appreciate if we could get this merged for the time until we all reach the 0.7 happy land.

@saschatimme saschatimme requested a review from blegat June 19, 2018 19:57
@coveralls
Copy link

coveralls commented Jun 19, 2018

Coverage Status

Coverage decreased (-1.02%) to 98.613% when pulling 1c245d4 on revert-#14 into 8b2b1a0 on master.

@codecov-io
Copy link

codecov-io commented Jun 19, 2018

Codecov Report

Merging #25 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #25   +/-   ##
=======================================
  Coverage   99.02%   99.02%           
=======================================
  Files          15       15           
  Lines         721      721           
=======================================
  Hits          714      714           
  Misses          7        7
Impacted Files Coverage Δ
src/mono.jl 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b2b1a0...1c245d4. Read the comment docs.

@saschatimme
Copy link
Contributor Author

@blegat I was a little bit too tired yesterday and forgot to disable all of the corresponding testcases for 0.6 but not everything works.

This bug is really strange, since it isn't even called in my code (otherwise there would have been a stackoverflow), nonetheless it crashes the compiler 🤷‍♂️

@blegat blegat merged commit e765453 into master Jun 20, 2018
@blegat
Copy link
Member

blegat commented Jun 20, 2018

Do you mean you get this crash ?

@saschatimme saschatimme deleted the revert-#14 branch August 7, 2018 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants