Fix star for SubBasis

JuliaAlgebra · Jul 5, 2024 · cd9d98b · cd9d98b
1 parent 2548ae1
commit cd9d98b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/src/monomial.jl b/src/monomial.jl
@@ -435,3 +435,6 @@ function SA.coeffs(
         return SA.coeffs!(res, cfs, source, target)
     end
 end
+
+# FIXME this assumes that the basis is invariant under adjoint
+SA.star(::SubBasis, coeffs) = SA.star.(coeffs)
diff --git a/test/runtests.jl b/test/runtests.jl
@@ -65,6 +65,7 @@ function api_test(B::Type{<:MB.AbstractMonomialIndexed}, degree)
         #@test polynomial(i -> 0.0, basis) isa polynomial_type(basis, Float64)
         a = MB.algebra_element(ones(length(basis)), basis)
         _test_op(MB.implicit, a)
+	@test SA.star(a) == a
     end
     mono = x[1]^2 * x[2]^3
     p = MB.Polynomial{B}(mono)