Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New design : implementation independent API #41

Merged
merged 42 commits into from
Aug 15, 2017
Merged

New design : implementation independent API #41

merged 42 commits into from
Aug 15, 2017

Conversation

blegat
Copy link
Member

@blegat blegat commented Jul 12, 2017

Rewrite of the code, it is now an implementation independent API. The implementation has been moved to DynamicPolynomials. The API is inspired from both DynamicPolynomials and TypedPolynomials.
There is a start of documentation of the API.
Still to do:

  • substitution
  • make TypedPolynomials pass the tests
  • run the tests for both TypedPolynomials and DynamicPolynomials on runtests.jl of this package

@rdeits What would you think of saying that variables gives the variables of nonzero exponent and vars gives all the variables of the type ?

@blegat blegat force-pushed the typed branch 2 times, most recently from 68472d3 to d9edc0c Compare July 12, 2017 16:25
@coveralls
Copy link

coveralls commented Jul 12, 2017

Coverage Status

Coverage decreased (-67.6%) to 26.41% when pulling d9edc0c on typed into 83297a5 on master.

@codecov
Copy link

codecov bot commented Jul 12, 2017

Codecov Report

Merging #41 into master will increase coverage by 4.27%.
The diff coverage is 98.1%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
+ Coverage   94.01%   98.28%   +4.27%     
==========================================
  Files          17       12       -5     
  Lines        1069      408     -661     
==========================================
- Hits         1005      401     -604     
+ Misses         64        7      -57
Impacted Files Coverage Δ
src/show.jl 100% <100%> (ø) ⬆️
src/rational.jl 100% <100%> (+10%) ⬆️
src/zip.jl 100% <100%> (ø)
src/div.jl 100% <100%> (+16.66%) ⬆️
src/comp.jl 100% <100%> (+2.25%) ⬆️
src/operators.jl 100% <100%> (ø)
src/mono.jl 100% <100%> (+6%) ⬆️
src/conversion.jl 100% <100%> (ø)
src/term.jl 100% <100%> (ø)
src/diff.jl 100% <100%> (ø) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83297a5...c7bec44. Read the comment docs.

@coveralls
Copy link

coveralls commented Jul 12, 2017

Coverage Status

Coverage decreased (-61.9%) to 32.08% when pulling 122c35e on typed into 83297a5 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-55.2%) to 38.765% when pulling 2f95508 on typed into 83297a5 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-55.2%) to 38.765% when pulling 2f95508 on typed into 83297a5 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-53.2%) to 40.786% when pulling bde13a5 on typed into 83297a5 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-53.2%) to 40.786% when pulling bde13a5 on typed into 83297a5 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-49.5%) to 44.526% when pulling fae284b on typed into 83297a5 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-45.09%) to 48.921% when pulling 1daada8 on typed into 83297a5 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-43.4%) to 50.597% when pulling af934b2 on typed into 83297a5 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-38.5%) to 55.476% when pulling a009287 on typed into 83297a5 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-33.0%) to 61.02% when pulling 6dc4417 on typed into 83297a5 on master.

@saschatimme
Copy link
Collaborator

saschatimme commented Aug 11, 2017

@rdeits I ran into the same Julia issue (even without reexport). It was not deterministic, but I think after I removed ˋRevise.jlˋ from my ˋjuliarc.jlˋ it didn’t occur again.

@blegat
Copy link
Member Author

blegat commented Aug 11, 2017

I also keep getting hit by JuliaLang/julia#22355. When this happens, I use Julia v0.7. Once I do a few changes this usually disappears but then it appears a few changes later :-P They seem to say that a fix is being backported to the next bug fix release of Julia v0.6.

@blegat
Copy link
Member Author

blegat commented Aug 11, 2017

We may strip out matpoly.jl from MultivariatePolynomials and put it in SumOfSquares.jl. Making this package lighter might make these failures less frequent.

@saschatimme
Copy link
Collaborator

algebraicset.jl also? That seems quite self contained.

@blegat
Copy link
Member Author

blegat commented Aug 11, 2017

Both TypedPolynomials and DynamicPolynomials are passing all the tests.
@rdeits Ok to merge this PR ?
I have removed MatPolynomial, SOSPolynomials and algebraic set stuff. The two first will be moved to SumOfSquares while the last will be moved to SemialgebraicSets.jl unless someone has a better name.

@coveralls
Copy link

Coverage Status

Coverage decreased (-14.5%) to 79.475% when pulling 987e6d8 on typed into 83297a5 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-8.7%) to 85.279% when pulling c6ebd42 on typed into 83297a5 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-8.7%) to 85.279% when pulling c6ebd42 on typed into 83297a5 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 94.177% when pulling 45bbc00 on typed into 83297a5 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.2%) to 95.202% when pulling fa66e08 on typed into 83297a5 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.5%) to 96.56% when pulling 0567d8c on typed into 83297a5 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+3.3%) to 97.304% when pulling 6875015 on typed into 83297a5 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+4.3%) to 98.284% when pulling bdf5351 on typed into 83297a5 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+5.5%) to 99.507% when pulling c7bec44 on typed into 83297a5 on master.

@blegat blegat merged commit ef33a4b into master Aug 15, 2017
@blegat blegat deleted the typed branch March 5, 2018 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants