-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New design : implementation independent API #41
Conversation
68472d3
to
d9edc0c
Compare
Codecov Report
@@ Coverage Diff @@
## master #41 +/- ##
==========================================
+ Coverage 94.01% 98.28% +4.27%
==========================================
Files 17 12 -5
Lines 1069 408 -661
==========================================
- Hits 1005 401 -604
+ Misses 64 7 -57
Continue to review full report at Codecov.
|
1 similar comment
1 similar comment
@rdeits I ran into the same Julia issue (even without reexport). It was not deterministic, but I think after I removed ˋRevise.jlˋ from my ˋjuliarc.jlˋ it didn’t occur again. |
I also keep getting hit by JuliaLang/julia#22355. When this happens, I use Julia v0.7. Once I do a few changes this usually disappears but then it appears a few changes later :-P They seem to say that a fix is being backported to the next bug fix release of Julia v0.6. |
We may strip out |
|
Both TypedPolynomials and DynamicPolynomials are passing all the tests. |
Rewrite of the code, it is now an implementation independent API. The implementation has been moved to DynamicPolynomials. The API is inspired from both DynamicPolynomials and TypedPolynomials.
There is a start of documentation of the API.
Still to do:
runtests.jl
of this package@rdeits What would you think of saying that
variables
gives the variables of nonzero exponent andvars
gives all the variables of the type ?