Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix deprecation warnings - constraint LinearAlgebra #132

Merged
merged 2 commits into from
Jan 13, 2024

Conversation

t-bltg
Copy link
Contributor

@t-bltg t-bltg commented Jan 13, 2024

This PR:

cc @hyrodium, @dlfivefifty.

@t-bltg t-bltg changed the title fix deprecations - constraint LinearAlgebra fix deprecation warnings - constraint LinearAlgebra Jan 13, 2024
Copy link

codecov bot commented Jan 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bd82113) 96.89% compared to head (3d04728) 96.89%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #132   +/-   ##
=======================================
  Coverage   96.89%   96.89%           
=======================================
  Files           9        9           
  Lines        1384     1384           
=======================================
  Hits         1341     1341           
  Misses         43       43           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@hyrodium hyrodium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Could you bump the version to v1.0.2?

@t-bltg
Copy link
Contributor Author

t-bltg commented Jan 13, 2024

Could you bump the version to v1.0.2?

Sure 😃, done !

@hyrodium hyrodium merged commit b654654 into JuliaApproximation:master Jan 13, 2024
12 checks passed
@hyrodium
Copy link
Collaborator

Thank you for the excellent contribution!

@t-bltg t-bltg deleted the depwarn branch January 13, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants