Support planning Chebyshev via specifying type and size

JuliaApproximation · Nov 15, 2023 · 77efdb0 · 77efdb0
1 parent 90d1dae
commit 77efdb0
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 13 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,6 +1,6 @@
 name = "FastTransforms"
 uuid = "057dd010-8810-581a-b7be-e3fc3b93f78c"
-version = "0.15.12"
+version = "0.15.13"
 
 [deps]
 AbstractFFTs = "621f4979-c628-5d54-868e-fcf4e3e8185c"

diff --git a/src/chebyshevtransform.jl b/src/chebyshevtransform.jl
@@ -49,9 +49,6 @@ function plan_chebyshevtransform(x::AbstractArray{T,N}, ::Val{2}, dims...; kws..
  ChebyshevTransformPlan{T,2}(FFTW.plan_r2r(x, SECONDKIND, dims...; kws...))
 end
 
-plan_chebyshevtransform!(x::AbstractArray, dims...; kws...) = plan_chebyshevtransform!(x, Val(1), dims...; kws...)
-plan_chebyshevtransform(x::AbstractArray, dims...; kws...) = plan_chebyshevtransform(x, Val(1), dims...; kws...)
-
 
 # convert x if necessary
 @inline _plan_mul!(y::AbstractArray{T}, P::Plan{T}, x::StridedArray{T}) where T = mul!(y, P, x)
@@ -275,9 +272,6 @@ function plan_ichebyshevtransform(x::AbstractArray{T}, ::Val{2}, dims...; kws...
  inv(plan_chebyshevtransform(x, Val(2), dims...; kws...))
 end
 
-plan_ichebyshevtransform!(x::AbstractArray, dims...; kws...) = plan_ichebyshevtransform!(x, Val(1), dims...; kws...)
-plan_ichebyshevtransform(x::AbstractArray, dims...; kws...) = plan_ichebyshevtransform(x, Val(1), dims...; kws...)
-
 @inline function _icheb1_prescale!(d::Number, x::AbstractArray)
  lmul_dim_begin!(2, d, x)
  x
@@ -423,9 +417,6 @@ function plan_chebyshevutransform(x::AbstractArray{T,N}, ::Val{2}, dims...; kws.
  ChebyshevUTransformPlan{T,2}(FFTW.plan_r2r(x, USECONDKIND, dims...; kws...))
 end
 
-plan_chebyshevutransform!(x::AbstractArray, dims...; kws...) = plan_chebyshevutransform!(x, Val(1), dims...; kws...)
-plan_chebyshevutransform(x::AbstractArray, dims...; kws...) = plan_chebyshevutransform(x, Val(1), dims...; kws...)
-
 
 _permfirst(d, N) = [d; 1:d-1; d+1:N]
 
@@ -580,9 +571,6 @@ function plan_ichebyshevutransform(x::AbstractArray{T,N}, ::Val{2}, dims...; kws
 end
 
 
-plan_ichebyshevutransform!(x::AbstractArray, dims...; kws...) = plan_ichebyshevutransform!(x, Val(1), dims...; kws...)
-plan_ichebyshevutransform(x::AbstractArray, dims...; kws...) = plan_ichebyshevutransform(x, Val(1), dims...; kws...)
-
 # second kind Chebyshev transforms share a plan with their inverse
 # so we support this via inv
 inv(P::ChebyshevUTransformPlan{T,2}) where {T} = IChebyshevUTransformPlan{T,2}(P.plan)
@@ -798,3 +786,14 @@ end
  copyto!(x, IChebyshevTransformPlan{T,1,Nothing,false,N,R}() * x)
 # *(P::IChebyshevTransformPlan{T,SECONDKIND,false,Nothing}, x::AbstractVector{T}) where T =
 # IChebyshevTransformPlan{T,SECONDKIND,true,Nothing}() * copy(x)
+
+
+for pln in (:plan_chebyshevtransform!, :plan_chebyshevtransform, 
+ :plan_chebyshevutransform!, :plan_chebyshevutransform, 
+ :plan_ichebyshevutransform, :plan_ichebyshevutransform!, 
+ :plan_ichebyshevtransform, :plan_ichebyshevtransform!)
+ @eval begin
+ $pln(x::AbstractArray, dims...; kws...) = $pln(x, Val(1), dims...; kws...)
+ $pln(::Type{T}, szs, dims...; kwds...) where T = $pln(Array{T}(undef, szs...), dims...; kwds...)
+ end
+end
diff --git a/test/chebyshevtests.jl b/test/chebyshevtests.jl
@@ -467,4 +467,10 @@ using FastTransforms, Test
  @test_throws ErrorException plan_chebyshevtransform(randn(5)) * randn(5,5)
  @test_throws ErrorException plan_ichebyshevtransform(randn(5)) * randn(5,5)
  end
+
+ @testset "plan via size" begin
+ X = randn(3,4)
+ p = plan_chebyshevtransform(Float64, (3,4))
+ @test p * X == chebyshevtransform(X)
+ end
 end