Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

\ is broken with matrix FFTs #23

Merged
merged 5 commits into from
Mar 25, 2023
Merged

\ is broken with matrix FFTs #23

merged 5 commits into from
Mar 25, 2023

Conversation

dlfivefifty
Copy link
Member

I found this bug, see the tests.

@codecov
Copy link

codecov bot commented Mar 25, 2023

Codecov Report

Patch coverage: 71.69% and project coverage change: +9.32 🎉

Comparison is base (64969bd) 69.39% compared to head (9e9d888) 78.72%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
+ Coverage   69.39%   78.72%   +9.32%     
==========================================
  Files           2        2              
  Lines         183      188       +5     
==========================================
+ Hits          127      148      +21     
+ Misses         56       40      -16     
Impacted Files Coverage Δ
src/fft.jl 79.23% <71.69%> (+9.57%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dlfivefifty dlfivefifty changed the title WIP: \ is broken with matrix FFTs \ is broken with matrix FFTs Mar 25, 2023
@dlfivefifty dlfivefifty merged commit 910b3a8 into main Mar 25, 2023
@dlfivefifty dlfivefifty deleted the dl/brokenifft branch March 25, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant