Merge pull request #100 from invenia/mz/getindex

fix the getindex bug for abstract arrays
JuliaArrays · May 18, 2022 · b2ee90a · b2ee90a · mzgubic · May 18, 2022
2 parents fc727ab + d77c395
commit b2ee90a
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,7 +1,7 @@
 name = "BlockDiagonals"
 uuid = "0a1fb500-61f7-11e9-3c65-f5ef3456f9f0"
 authors = ["Invenia Technical Computing Corporation"]
-version = "0.1.29"
+version = "0.1.30"
 
 [deps]
 ChainRulesCore = "d360d2e6-b24c-11e9-a2a3-2a2ae2dbcce4"

diff --git a/src/blockdiagonal.jl b/src/blockdiagonal.jl
@@ -152,7 +152,8 @@ function _block_indices(B::BlockDiagonal, i::Integer, j::Integer)
  p += 1
  j -= blocksize(B, p)[2]
  end
- @views @inbounds i -= sum(size.(blocks(B)[1:(p-1)], 1))
+ # isempty to avoid reducing over an empty collection
+ @views @inbounds i -= isempty(1:(p-1)) ? 0 : sum(size.(blocks(B)[1:(p-1)], 1))
  # if row `i` outside of block `p`, set `p` to place-holder value `-1`
  if i <= 0 || i > blocksize(B, p)[1]
  p = -1

diff --git a/test/blockdiagonal.jl b/test/blockdiagonal.jl
@@ -124,4 +124,9 @@ using Test
 
  @test_throws DimensionMismatch copy!(b2, b1)
  end
+
+ @testset "getindex bug" begin
+ b = BlockDiagonal(AbstractMatrix{Float64}[ones(2, 2)])
+ @test b[1] == 1
+ end
 end